Add RBAC annotation for Services to InstanceHA controller

The controller creates a metrics Service but was missing the
kubebuilder RBAC marker for core/services.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: lmiccini

internal/controller/instanceha/instanceha_controller.go

@@ -81,6 +81,7 @@ func (r *Reconciler) GetLogger(ctx context.Context) logr.Logger {
 // +kubebuilder:rbac:groups=instanceha.openstack.org,resources=instancehas/finalizers,verbs=update;patch
 // +kubebuilder:rbac:groups=core,resources=configmaps,verbs=get;list;watch;
 // +kubebuilder:rbac:groups=core,resources=secrets,verbs=get;list;watch;
+// +kubebuilder:rbac:groups=core,resources=services,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups=k8s.cni.cncf.io,resources=network-attachment-definitions,verbs=get;list;watch
 // service account, role, rolebinding
 // +kubebuilder:rbac:groups="",resources=serviceaccounts,verbs=get;list;watch;create;update;patch

test/functional/instanceha_controller_test.go

@@ -21,6 +21,7 @@ import (
 	. "github.com/onsi/gomega"    //revive:disable:dot-imports
 
 	condition "github.com/openstack-k8s-operators/lib-common/modules/common/condition"
+	//revive:disable-next-line:dot-imports
 	. "github.com/openstack-k8s-operators/lib-common/modules/common/test/helpers"
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/types"
@@ -63,7 +64,7 @@ var _ = Describe("InstanceHa Controller", func() {
 			DeferCleanup(k8sClient.Delete, ctx, th.CreateConfigMap(types.NamespacedName{
 				Name:      "openstack-config",
 				Namespace: namespace,
-			}, map[string]interface{}{
+			}, map[string]any{
 				"clouds.yaml": "test-data",
 			}))
 
@@ -141,7 +142,7 @@ var _ = Describe("InstanceHa Controller", func() {
 			DeferCleanup(k8sClient.Delete, ctx, th.CreateConfigMap(types.NamespacedName{
 				Name:      "openstack-config",
 				Namespace: namespace,
-			}, map[string]interface{}{
+			}, map[string]any{
 				"clouds.yaml": "test-data",
 			}))