Migrate terminationGracePeriodSeconds from 604800 to 60 in webhook

The upstream rabbitmq-cluster-operator defaults to 604800s (7 days) for
terminationGracePeriodSeconds. Combined with containers that do not
handle SIGTERM properly, this causes pods to stay in Terminating state
for days. Add a defaulting webhook that sets the value to 60s for
existing clusters still carrying the old default.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: lmiccini

apis/rabbitmq/v1beta1/rabbitmq_webhook.go

@@ -140,6 +140,16 @@ func (spec *RabbitMqSpecCore) Default(isNew bool) {
 		spec.QueueType = &queueType
 	}
 
+	// Migrate terminationGracePeriodSeconds from old default (604800) to new (60).
+	// The old value was inherited from rabbitmq-cluster-operator and causes pods
+	// to get stuck in Terminating state for up to a week.
+	oldGracePeriod := int64(604800)
+	newGracePeriod := int64(60)
+	if spec.TerminationGracePeriodSeconds != nil && *spec.TerminationGracePeriodSeconds == oldGracePeriod {
+		spec.TerminationGracePeriodSeconds = &newGracePeriod
+		rabbitmqlog.Info("Migrating terminationGracePeriodSeconds from old default 604800 to 60")
+	}
+
 	// Force Mirrored → Quorum when upgrading to RabbitMQ 4.x+.
 	// Mirrored queues are not supported in 4.x, so the migration is mandatory.
 	if spec.QueueType != nil && *spec.QueueType == QueueTypeMirrored &&

apis/rabbitmq/v1beta1/rabbitmq_webhook_test.go

@@ -0,0 +1,67 @@
+/*
+Copyright 2025.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package v1beta1
+
+import "testing"
+
+func TestSpecCoreDefault_MigratesOldGracePeriod(t *testing.T) {
+	oldDefault := int64(604800)
+	spec := RabbitMqSpecCore{
+		TerminationGracePeriodSeconds: &oldDefault,
+	}
+
+	spec.Default(false)
+
+	if spec.TerminationGracePeriodSeconds == nil {
+		t.Fatal("TerminationGracePeriodSeconds should not be nil")
+	}
+	if *spec.TerminationGracePeriodSeconds != 60 {
+		t.Errorf("TerminationGracePeriodSeconds = %d, want 60", *spec.TerminationGracePeriodSeconds)
+	}
+}
+
+func TestSpecCoreDefault_PreservesCustomGracePeriod(t *testing.T) {
+	custom := int64(120)
+	spec := RabbitMqSpecCore{
+		TerminationGracePeriodSeconds: &custom,
+	}
+
+	spec.Default(false)
+
+	if spec.TerminationGracePeriodSeconds == nil {
+		t.Fatal("TerminationGracePeriodSeconds should not be nil")
+	}
+	if *spec.TerminationGracePeriodSeconds != 120 {
+		t.Errorf("TerminationGracePeriodSeconds = %d, want 120", *spec.TerminationGracePeriodSeconds)
+	}
+}
+
+func TestSpecCoreDefault_PreservesNewDefault(t *testing.T) {
+	newDefault := int64(60)
+	spec := RabbitMqSpecCore{
+		TerminationGracePeriodSeconds: &newDefault,
+	}
+
+	spec.Default(false)
+
+	if spec.TerminationGracePeriodSeconds == nil {
+		t.Fatal("TerminationGracePeriodSeconds should not be nil")
+	}
+	if *spec.TerminationGracePeriodSeconds != 60 {
+		t.Errorf("TerminationGracePeriodSeconds = %d, want 60", *spec.TerminationGracePeriodSeconds)
+	}
+}