Skip to content

[golang] bump to golang 1.23#427

Closed
stuggi wants to merge 3 commits into
openstack-k8s-operators:mainfrom
stuggi:golang_1.23
Closed

[golang] bump to golang 1.23#427
stuggi wants to merge 3 commits into
openstack-k8s-operators:mainfrom
stuggi:golang_1.23

Conversation

@stuggi

@stuggi stuggi commented Aug 18, 2025

Copy link
Copy Markdown
Contributor
  • bump in go.mod (base and api)
  • bump go-toolset in Dockerfile
  • bump in github jobs ('.github/workflows')
  • Bump the golangci-lint version in the .pre-commit-config.yaml to v2.4.0
  • Bump build_root_image in .ci-operator.yaml to ci-build-root-golang-1.23-sdk-1.31 (if set)

To test on existing env:

  • update golang to 1.23
  • delete current go.work* files
  • init go work files go work init

Depends-On: openstack-k8s-operators/install_yamls#1080
Depends-On: openstack-k8s-operators/openstack-operator#1564

Jira: OSPRH-12935

@openshift-ci

openshift-ci Bot commented Aug 18, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested a review from dprince August 18, 2025 07:41
@softwarefactory-project-zuul

Copy link
Copy Markdown

This change depends on a change that failed to merge.

Change openstack-k8s-operators/openstack-operator#1564 is needed.

stuggi added 3 commits August 18, 2025 09:50
* bump in go.mod (base and api)
* bump go-toolset in Dockerfile
* bump in github jobs ('.github/workflows')
* Bump the golangci-lint version in the .pre-commit-config.yaml to v2.4.0
* Bump build_root_image in .ci-operator.yaml to ci-build-root-golang-1.23-sdk-1.31

Jira: OSPRH-12935
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
@openshift-ci

openshift-ci Bot commented Aug 18, 2025

Copy link
Copy Markdown
Contributor

@stuggi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/functional 6d4788b link true /test functional
ci/prow/infra-operator-build-deploy-kuttl 6d4788b link true /test infra-operator-build-deploy-kuttl
ci/prow/precommit-check 6d4788b link true /test precommit-check
ci/prow/images 6d4788b link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stuggi

stuggi commented Aug 18, 2025

Copy link
Copy Markdown
Contributor Author

closing in favor of #428

@stuggi stuggi closed this Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant