Skip to content

[golang] bump to golang 1.24#428

Merged
openshift-merge-bot[bot] merged 4 commits into
openstack-k8s-operators:mainfrom
stuggi:golang_1.24
Sep 22, 2025
Merged

[golang] bump to golang 1.24#428
openshift-merge-bot[bot] merged 4 commits into
openstack-k8s-operators:mainfrom
stuggi:golang_1.24

Conversation

@stuggi

@stuggi stuggi commented Aug 18, 2025

Copy link
Copy Markdown
Contributor
  • bump in go.mod (base and api)
  • bump go-toolset in Dockerfile
  • bump in github jobs ('.github/workflows')
  • Bump the golangci-lint version in the .pre-commit-config.yaml to v2.4.0
  • Bump build_root_image in .ci-operator.yaml to ci-build-root-golang-1.24-sdk-1.31 (if set)

Also bump dependencies for OpenShift 4.18. Update controller-runtime, Kubernetes dependencies, and testing tools to support OpenShift Container Platform 4.18 (Kubernetes 1.31):

  • controller-runtime: v0.17.6 → v0.19.7
  • Kubernetes core dependencies: v0.29.15 → v0.31.12
    • k8s.io/api: v0.31.12
    • k8s.io/apimachinery: v0.31.12
    • k8s.io/client-go: v0.31.12
    • k8s.io/apiextensions-apiserver: v0.31.12
  • k8s.io/utils: v0.0.0-20240711033017 → v0.0.0-20250820121507
  • controller-gen: v0.14.0 → v0.18.0
  • envtest: 1.29 → 1.31.0, setup-envtest@latest

To test on existing env, or after landed:

  • update golang to 1.24
  • delete current go.work* files
  • init go work files go work init
  • Delete tools in bin/ subdir of the repo

Depends-On: openstack-k8s-operators/install_yamls#1082
Depends-On: openstack-k8s-operators/openstack-operator#1567

Jira: OSPRH-12935

@softwarefactory-project-zuul

Copy link
Copy Markdown

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/install_yamls for 1080,2e97f86f0bbf64bc90c62c9253dd007317efba92

@stuggi

stuggi commented Aug 18, 2025

Copy link
Copy Markdown
Contributor Author

/test precommit-check

@stuggi

stuggi commented Aug 18, 2025

Copy link
Copy Markdown
Contributor Author

recheck

@stuggi stuggi force-pushed the golang_1.24 branch 2 times, most recently from 24ceef7 to d47401d Compare August 22, 2025 08:08
@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/82c46c1c06834a8abaee822927e33a69

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 54m 41s
podified-multinode-edpm-deployment-crc RETRY_LIMIT in 9m 31s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 35m 21s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 39s

@stuggi

stuggi commented Aug 22, 2025

Copy link
Copy Markdown
Contributor Author

recheck

1 similar comment
@stuggi

stuggi commented Aug 25, 2025

Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul

Copy link
Copy Markdown

This change depends on a change that failed to merge.

Change openstack-k8s-operators/openstack-operator#1567 is needed.

@softwarefactory-project-zuul

Copy link
Copy Markdown

This change depends on a change that failed to merge.

Change openstack-k8s-operators/openstack-operator#1567 is needed.

@stuggi stuggi force-pushed the golang_1.24 branch 2 times, most recently from 2298cce to e512610 Compare September 22, 2025 09:18
@softwarefactory-project-zuul

Copy link
Copy Markdown

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/openstack-operator for 1567,3c2b2fd018c29bcb34831d1f75847ec583f24ffb

* bump in go.mod (base and api)
* bump go-toolset in Dockerfile
* bump in github jobs ('.github/workflows')
* Bump the golangci-lint version in the .pre-commit-config.yaml to v2.4.0
* Bump build_root_image in .ci-operator.yaml to ci-build-root-golang-1.24-sdk-1.31

Also fixes golangci-lint reported issues for new v2.4.0 version.

Jira: OSPRH-12935
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Update controller-runtime, Kubernetes dependencies, and testing tools
to support OpenShift Container Platform 4.18 (Kubernetes 1.31).

Changes:
- controller-runtime: v0.17.6 → v0.19.7
- Kubernetes core dependencies: v0.29.15 → v0.31.12
  * k8s.io/api: v0.31.12
  * k8s.io/apimachinery: v0.31.12
  * k8s.io/client-go: v0.31.12
  * k8s.io/apiextensions-apiserver: v0.31.12
- k8s.io/utils: v0.0.0-20240711033017 → v0.0.0-20250820121507
- controller-gen: v0.14.0 → v0.18.0
- envtest: 1.29 → 1.31, setup-envtest@latest

Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
@softwarefactory-project-zuul

Copy link
Copy Markdown

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/openstack-operator for 1567,3c2b2fd018c29bcb34831d1f75847ec583f24ffb

@stuggi

stuggi commented Sep 22, 2025

Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ef1befd31bcd45798ddc7f66473080e0

openstack-k8s-operators-content-provider RETRY_LIMIT in 53s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ cifmw-pod-zuul-files SUCCESS in 4m 28s

@stuggi

stuggi commented Sep 22, 2025

Copy link
Copy Markdown
Contributor Author

recheck

@stuggi stuggi requested a review from abays September 22, 2025 10:55
@openshift-ci

openshift-ci Bot commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi

stuggi commented Sep 22, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-merge-bot openshift-merge-bot Bot merged commit 057562f into openstack-k8s-operators:main Sep 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants