Resolve InstanceHa container image from ConfigMap before fallback - #634
Conversation
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 10m 46s |
|
recheck |
|
/test infra-operator-build-deploy-kuttl |
1 similar comment
|
/test infra-operator-build-deploy-kuttl |
d95be1b to
71a3112
Compare
The webhook was always defaulting spec.containerImage, which meant the controller never reached the ConfigMap lookup path. This made the infra-instanceha-config ConfigMap (managed by openstack-operator via OpenStackVersion) effectively dead code. Remove the ContainerImage webhook defaulting and reorder the resolution in GetContainerImage() so the priority is: 1. spec.containerImage (explicit user override) 2. infra-instanceha-config ConfigMap (openstack-operator managed) 3. RELATED_IMAGE env var / hardcoded fallback (standalone deployment) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
71a3112 to
c44045c
Compare
|
/test infra-operator-build-deploy-kuttl |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmiccini, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 49m 46s |
|
recheck |
|
/test infra-operator-build-deploy-kuttl |
|
/cherry-pick 18-stable |
|
@lmiccini: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
517307d
into
openstack-k8s-operators:main
|
@lmiccini: new pull request created: #641 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
The webhook was always defaulting spec.containerImage, which meant the controller never reached the ConfigMap lookup path. This made the infra-instanceha-config ConfigMap (managed by openstack-operator via OpenStackVersion) effectively dead code.
Remove the ContainerImage webhook defaulting and reorder the resolution in GetContainerImage() so the priority is:
Jira: https://redhat.atlassian.net/browse/OSPRH-33358