[18.0-fr6] Resolve InstanceHa container image from ConfigMap before fallback - #642
Merged
openshift-merge-bot[bot] merged 1 commit intoJul 28, 2026
Conversation
The webhook was always defaulting spec.containerImage, which meant the controller never reached the ConfigMap lookup path. This made the infra-instanceha-config ConfigMap (managed by openstack-operator via OpenStackVersion) effectively dead code. Remove the ContainerImage webhook defaulting and reorder the resolution in GetContainerImage() so the priority is: 1. spec.containerImage (explicit user override) 2. infra-instanceha-config ConfigMap (openstack-operator managed) 3. RELATED_IMAGE env var / hardcoded fallback (standalone deployment) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lmiccini
approved these changes
Jul 28, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmiccini, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 38m 07s |
Contributor
|
recheck |
openshift-merge-bot
Bot
merged commit Jul 28, 2026
011c6b9
into
openstack-k8s-operators:18.0-fr6
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #641
/assign lmiccini