Split appcred finalizer management#723
Merged
openshift-merge-bot[bot] merged 1 commit intoMay 26, 2026
Merged
Conversation
The AC finalizer management is now split into two phases: Early phase: adds consumer finalizer to the new AC secret immediately (protects it from premature revocation) Late phase: removes consumer finalizer from the old AC secret only after AllSubConditionIsTrue() This prevents a race condition where rapid AC rotations could revoke credentials still in use by running pods. Signed-off-by: Veronika Fisarova <vfisarov@redhat.com>
hjensas
approved these changes
May 26, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Deydra71, hjensas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 19657d0
into
openstack-k8s-operators:main
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the discussion in watcher-operator the AC finalizer management is now split into two phases:
AllSubConditionIsTrue()This prevents a race condition where rapid AC rotations could revoke credentials still in use by running pods. The same pattern is implemented in all service operators with application credential support.
Note: the rotation env test now requires the parent Ironic CR to reach full Ready state.
simulateIronicSubServicesReadydrives all subCRs to Ready by simulating their resources.