Skip to content

Remove unnecessary pods RBAC permissions - #732

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
stuggi:rbac-cleanup-pods
Jul 25, 2026
Merged

Remove unnecessary pods RBAC permissions#732
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
stuggi:rbac-cleanup-pods

Conversation

@stuggi

@stuggi stuggi commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

The workload rbacRules and kubebuilder RBAC markers granted the operator and its workload service account full CRUD (create/delete/get/list/patch/update/ watch) on core Pods, but the operator never reads or writes Pod objects directly — pods only ever come into being indirectly via Deployments/ StatefulSets/Jobs. Remove the unused pods permission and regenerate config/rbac/role.yaml.

The workload rbacRules and kubebuilder RBAC markers granted the operator and
its workload service account full CRUD (create/delete/get/list/patch/update/
watch) on core Pods, but the operator never reads or writes Pod objects
directly — pods only ever come into being indirectly via Deployments/
StatefulSets/Jobs. Remove the unused pods permission and regenerate
config/rbac/role.yaml.

Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
@openshift-ci
openshift-ci Bot requested review from Deydra71 and millevy July 24, 2026 13:59
@stuggi

stuggi commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/47e41578c83346b9a9d17a94934f2d7d

✔️ keystone-openstack-meta-content-provider-master SUCCESS in 1h 41m 54s (non-voting)
keystone-operator-tempest-master FAILURE in 1h 15m 21s (non-voting)
openstack-k8s-operators-content-provider FAILURE in 14m 20s
⚠️ keystone-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ keystone-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

@abays abays left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi

stuggi commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@stuggi

stuggi commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

recheck

@openshift-merge-bot
openshift-merge-bot Bot merged commit 3d6a573 into openstack-k8s-operators:main Jul 25, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants