fix golangci reported issues

Signed-off-by: Martin Schuppert <mschuppert@redhat.com>

Author: stuggi

modules/certmanager/certificate.go

@@ -158,7 +158,7 @@ func (c *Certificate) Delete(
 
 	err := h.GetClient().Delete(ctx, c.certificate)
 	if err != nil && !k8s_errors.IsNotFound(err) {
-		return fmt.Errorf("Error deleting certificate %s: %w", c.certificate.Name, err)
+		return fmt.Errorf("error deleting certificate %s: %w", c.certificate.Name, err)
 	}
 
 	return nil
@@ -177,7 +177,7 @@ func EnsureCert(
 
 	err := helper.GetClient().Get(ctx, types.NamespacedName{Name: request.IssuerName, Namespace: namespace}, issuer)
 	if err != nil {
-		err = fmt.Errorf("Error getting issuer %s/%s - %w", request.IssuerName, namespace, err)
+		err = fmt.Errorf("error getting issuer %s/%s - %w", request.IssuerName, namespace, err)
 
 		return nil, ctrl.Result{}, err
 	}

modules/certmanager/issuer.go

@@ -159,7 +159,7 @@ func (i *Issuer) Delete(
 
 	err := h.GetClient().Delete(ctx, i.issuer)
 	if err != nil && !k8s_errors.IsNotFound(err) {
-		return fmt.Errorf("Error deleting issuer %s: %w", i.issuer.Name, err)
+		return fmt.Errorf("error deleting issuer %s: %w", i.issuer.Name, err)
 	}
 
 	return nil
@@ -177,7 +177,7 @@ func GetIssuerByName(
 
 	err := h.GetClient().Get(ctx, types.NamespacedName{Name: name, Namespace: namespace}, issuer)
 	if err != nil {
-		return nil, fmt.Errorf("Error getting issuer %s: %w", issuer.Name, err)
+		return nil, fmt.Errorf("error getting issuer %s: %w", issuer.Name, err)
 	}
 
 	return issuer, nil
@@ -204,7 +204,7 @@ func GetIssuerByLabels(
 
 	err := h.GetClient().List(ctx, issuers, listOpts...)
 	if err != nil {
-		return nil, fmt.Errorf("Error getting issuer by label: %w", err)
+		return nil, fmt.Errorf("error getting issuer by label: %w", err)
 	}
 
 	if len(issuers.Items) > 1 {

modules/common/affinity/affinity.go

@@ -14,6 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
+// Package affinity provides utilities for managing Kubernetes pod affinity and anti-affinity rules
 package affinity
 
 import (

modules/common/affinity/affinity_test.go

@@ -19,7 +19,7 @@ package affinity
 import (
 	"testing"
 
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/gomega" // nolint:revive
 
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

modules/common/annotations/network.go

@@ -14,6 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
+// Package annotations provides utilities for managing network annotations and network attachment definitions
 package annotations
 
 import (

modules/common/annotations/network_test.go

@@ -17,8 +17,9 @@ limitations under the License.
 package annotations
 
 import (
-	. "github.com/onsi/gomega"
 	"testing"
+
+	. "github.com/onsi/gomega" // nolint:revive
 )
 
 func TestGetNADAnnotation(t *testing.T) {

modules/common/clusterdns/clusterdns.go

@@ -14,6 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
+// Package clusterdns provides utilities for DNS cluster domain operations
 package clusterdns
 
 // GetDNSClusterDomain - Return openshift dns Cluster Domain name

modules/common/condition/conditions.go

@@ -16,6 +16,7 @@ limitations under the License.
 
 // +kubebuilder:object:generate:=true
 
+// Package condition provides types and utilities for managing Kubernetes condition objects
 package condition
 
 // Common Condition Types used by API objects.

modules/common/condition/funcs_test.go

@@ -22,7 +22,7 @@ import (
 	"testing"
 	"time"
 
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/gomega" // nolint:revive
 	"github.com/onsi/gomega/format"
 	"github.com/onsi/gomega/types"
 	"github.com/pkg/errors"
@@ -148,7 +148,7 @@ func TestSet(t *testing.T) {
 	g.Expect(conditions).To(haveSameConditionsOf(CreateList(unknownReady)))
 
 	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
+		t.Run(tt.name, func(_ *testing.T) {
 
 			conditions.Set(tt.condition)
 
@@ -224,7 +224,7 @@ func TestRemove(t *testing.T) {
 	g := NewWithT(t)
 
 	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
+		t.Run(tt.name, func(_ *testing.T) {
 			tt.conditions.Remove(tt.cType)
 			g.Expect(tt.expected).To(haveSameConditionsOf(tt.conditions))
 		})
@@ -256,7 +256,7 @@ func TestReset(t *testing.T) {
 	g := NewWithT(t)
 
 	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
+		t.Run(tt.name, func(_ *testing.T) {
 			tt.conditions.Reset()
 			g.Expect(tt.expected).To(haveSameConditionsOf(tt.conditions))
 		})
@@ -400,7 +400,7 @@ func TestAllSubConditionIsTrue(t *testing.T) {
 	g.Expect(conditions).To(haveSameConditionsOf(CreateList(unknownReady)))
 
 	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
+		t.Run(tt.name, func(_ *testing.T) {
 
 			conditions.Set(tt.condition)
 			g.Expect(conditions.AllSubConditionIsTrue()).To(BeIdenticalTo(tt.want))
@@ -651,14 +651,14 @@ func TestRestoreLastTransitionTimes(t *testing.T) {
 		// LastTransitionTime should change to time2 when HasSameCondition() passes.
 		{
 			name:  "Same condition state",
-			patch: func(condition *Condition) {},
+			patch: func(_ *Condition) {},
 			want:  time2,
 		},
 	}
 
 	g := NewWithT(t)
 	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
+		t.Run(tt.name, func(_ *testing.T) {
 			testCond := falseA.DeepCopy()
 			testCond.LastTransitionTime = time1
 			conditions := CreateList(testCond)

modules/common/configmap/configmap.go

@@ -14,6 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
+// Package configmap provides utilities for managing Kubernetes ConfigMap resources
 package configmap
 
 import (
@@ -202,7 +203,7 @@ func EnsureConfigMaps(
 func GetConfigMaps(
 	ctx context.Context,
 	h *helper.Helper,
-	obj client.Object,
+	_ client.Object,
 	configMaps []string,
 	namespace string,
 	envVars *map[string]env.Setter,
@@ -289,7 +290,7 @@ func VerifyConfigMap(
 				ctrl.Result{RequeueAfter: requeueTimeout},
 				nil
 		}
-		return "", ctrl.Result{}, fmt.Errorf("Get ConfigMap %s failed: %w", configMapName, err)
+		return "", ctrl.Result{}, fmt.Errorf("get ConfigMap %s failed: %w", configMapName, err)
 	}
 
 	// collect the ConfigMap values the caller expects to exist