Skip to content

Commit 03b05cb

Browse files
committed
Default transcriptsEnabled to false
The config option transcriptsEnabled now defaults to false. Passive data collection should require the explicit approval of the user first. Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
1 parent 9acfd20 commit 03b05cb

7 files changed

Lines changed: 11 additions & 9 deletions

File tree

api/v1beta1/openstacklightspeed_types.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,9 +186,8 @@ type OpenStackLightspeedCore struct {
186186
FeedbackEnabled *bool `json:"feedbackEnabled,omitempty"`
187187

188188
// +kubebuilder:validation:Optional
189-
// +kubebuilder:default=true
190189
// Enable conversation transcripts collection
191-
TranscriptsEnabled *bool `json:"transcriptsEnabled,omitempty"`
190+
TranscriptsEnabled bool `json:"transcriptsEnabled,omitempty"`
192191

193192
// +kubebuilder:validation:Optional
194193
// +kubebuilder:default={}

api/v1beta1/zz_generated.deepcopy.go

Lines changed: 6 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bundle/manifests/lightspeed.openstack.org_openstacklightspeeds.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,6 @@ spec:
173173
description: Configmap name containing a CA Certificates bundle
174174
type: string
175175
transcriptsEnabled:
176-
default: true
177176
description: Enable conversation transcripts collection
178177
type: boolean
179178
required:

bundle/manifests/openstack-lightspeed-operator.clusterserviceversion.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ metadata:
2525
]
2626
capabilities: Basic Install
2727
categories: AI/Machine Learning
28-
createdAt: "2026-07-09T10:17:14Z"
28+
createdAt: "2026-07-13T09:32:13Z"
2929
description: AI-powered virtual assistant for Red Hat OpenStack Services on OpenShift
3030
features.operators.openshift.io/cnf: "false"
3131
features.operators.openshift.io/cni: "false"

config/crd/bases/lightspeed.openstack.org_openstacklightspeeds.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,6 @@ spec:
173173
description: Configmap name containing a CA Certificates bundle
174174
type: string
175175
transcriptsEnabled:
176-
default: true
177176
description: Enable conversation transcripts collection
178177
type: boolean
179178
required:

internal/controller/lcore_config.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ func buildLCoreLlamaStackConfig() map[string]interface{} {
101101

102102
func buildLCoreUserDataCollectionConfig(_ *common_helper.Helper, instance *apiv1beta1.OpenStackLightspeed) map[string]interface{} {
103103
feedbackEnabled := instance.Spec.FeedbackEnabled == nil || *instance.Spec.FeedbackEnabled
104-
transcriptsEnabled := instance.Spec.TranscriptsEnabled == nil || *instance.Spec.TranscriptsEnabled
104+
transcriptsEnabled := instance.Spec.TranscriptsEnabled
105105

106106
return map[string]interface{}{
107107
"feedback_enabled": feedbackEnabled,
@@ -176,7 +176,7 @@ func buildLCoreConversationCacheConfig(h *common_helper.Helper, _ *apiv1beta1.Op
176176

177177
// isDataCollectionEnabled returns true if at least one of feedback or transcripts is enabled.
178178
func isDataCollectionEnabled(instance *apiv1beta1.OpenStackLightspeed) bool {
179-
return (instance.Spec.FeedbackEnabled == nil || *instance.Spec.FeedbackEnabled) || (instance.Spec.TranscriptsEnabled == nil || *instance.Spec.TranscriptsEnabled)
179+
return (instance.Spec.FeedbackEnabled == nil || *instance.Spec.FeedbackEnabled) || instance.Spec.TranscriptsEnabled
180180
}
181181

182182
// buildExporterConfigMap creates the ConfigMap for the dataverse exporter sidecar.

test/kuttl/common/expected-configs/lightspeed-stack.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,5 +92,5 @@ service:
9292
user_data_collection:
9393
feedback_enabled: true
9494
feedback_storage: /tmp/data/feedback
95-
transcripts_enabled: true
95+
transcripts_enabled: false
9696
transcripts_storage: /tmp/data/transcripts

0 commit comments

Comments
 (0)