Default transcriptsEnabled to false

The config option transcriptsEnabled now defaults to false. Passive data
collection should require the explicit approval of the user first.

Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>

Author: umago

api/v1beta1/openstacklightspeed_types.go

@@ -186,9 +186,8 @@ type OpenStackLightspeedCore struct {
 	FeedbackEnabled *bool `json:"feedbackEnabled,omitempty"`
 
 	// +kubebuilder:validation:Optional
-	// +kubebuilder:default=true
 	// Enable conversation transcripts collection
-	TranscriptsEnabled *bool `json:"transcriptsEnabled,omitempty"`
+	TranscriptsEnabled bool `json:"transcriptsEnabled,omitempty"`
 
 	// +kubebuilder:validation:Optional
 	// +kubebuilder:default={}

bundle/manifests/lightspeed.openstack.org_openstacklightspeeds.yaml

@@ -173,7 +173,6 @@ spec:
                 description: Configmap name containing a CA Certificates bundle
                 type: string
               transcriptsEnabled:
-                default: true
                 description: Enable conversation transcripts collection
                 type: boolean
             required:

config/crd/bases/lightspeed.openstack.org_openstacklightspeeds.yaml

@@ -173,7 +173,6 @@ spec:
                 description: Configmap name containing a CA Certificates bundle
                 type: string
               transcriptsEnabled:
-                default: true
                 description: Enable conversation transcripts collection
                 type: boolean
             required:

internal/controller/lcore_config.go

@@ -101,7 +101,7 @@ func buildLCoreLlamaStackConfig() map[string]interface{} {
 
 func buildLCoreUserDataCollectionConfig(_ *common_helper.Helper, instance *apiv1beta1.OpenStackLightspeed) map[string]interface{} {
 	feedbackEnabled := instance.Spec.FeedbackEnabled == nil || *instance.Spec.FeedbackEnabled
-	transcriptsEnabled := instance.Spec.TranscriptsEnabled == nil || *instance.Spec.TranscriptsEnabled
+	transcriptsEnabled := instance.Spec.TranscriptsEnabled
 
 	return map[string]interface{}{
 		"feedback_enabled":    feedbackEnabled,
@@ -176,7 +176,7 @@ func buildLCoreConversationCacheConfig(h *common_helper.Helper, _ *apiv1beta1.Op
 
 // isDataCollectionEnabled returns true if at least one of feedback or transcripts is enabled.
 func isDataCollectionEnabled(instance *apiv1beta1.OpenStackLightspeed) bool {
-	return (instance.Spec.FeedbackEnabled == nil || *instance.Spec.FeedbackEnabled) || (instance.Spec.TranscriptsEnabled == nil || *instance.Spec.TranscriptsEnabled)
+	return (instance.Spec.FeedbackEnabled == nil || *instance.Spec.FeedbackEnabled) || instance.Spec.TranscriptsEnabled
 }
 
 // buildExporterConfigMap creates the ConfigMap for the dataverse exporter sidecar.

test/kuttl/common/expected-configs/lightspeed-stack.yaml

@@ -92,5 +92,5 @@ service:
 user_data_collection:
   feedback_enabled: true
   feedback_storage: /tmp/data/feedback
-  transcripts_enabled: true
+  transcripts_enabled: false
   transcripts_storage: /tmp/data/transcripts