Rename feedback and transcripts config options

Inverts the boolean semantics so users set true to enable a feature
rather than false.

- feedbackDisabled was renamed to feedbackEnabled.
- transcriptsDisabled was renamed to transcriptsEnabled.

Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>

Author: umago

api/v1beta1/openstacklightspeed_types.go

@@ -181,12 +181,14 @@ type OpenStackLightspeedCore struct {
 	LLMAPIVersion string `json:"llmAPIVersion,omitempty"`
 
 	// +kubebuilder:validation:Optional
-	// Disable feedback collection
-	FeedbackDisabled bool `json:"feedbackDisabled,omitempty"`
+	// +kubebuilder:default=true
+	// Enable feedback collection
+	FeedbackEnabled *bool `json:"feedbackEnabled,omitempty"`
 
 	// +kubebuilder:validation:Optional
-	// Disable conversation transcripts collection
-	TranscriptsDisabled bool `json:"transcriptsDisabled,omitempty"`
+	// +kubebuilder:default=true
+	// Enable conversation transcripts collection
+	TranscriptsEnabled *bool `json:"transcriptsEnabled,omitempty"`
 
 	// +kubebuilder:validation:Optional
 	// +kubebuilder:default={}

bundle/manifests/lightspeed.openstack.org_openstacklightspeeds.yaml

@@ -75,8 +75,9 @@ spec:
                   This section is not part of the stable API and may change at any time without backward compatibility.
                 type: object
                 x-kubernetes-preserve-unknown-fields: true
-              feedbackDisabled:
-                description: Disable feedback collection
+              feedbackEnabled:
+                default: true
+                description: Enable feedback collection
                 type: boolean
               llmAPIVersion:
                 description: LLM API Version for LLM providers that require it (e.g.,
@@ -171,8 +172,9 @@ spec:
               tlsCACertBundle:
                 description: Configmap name containing a CA Certificates bundle
                 type: string
-              transcriptsDisabled:
-                description: Disable conversation transcripts collection
+              transcriptsEnabled:
+                default: true
+                description: Enable conversation transcripts collection
                 type: boolean
             required:
             - llmCredentials

config/crd/bases/lightspeed.openstack.org_openstacklightspeeds.yaml

@@ -75,8 +75,9 @@ spec:
                   This section is not part of the stable API and may change at any time without backward compatibility.
                 type: object
                 x-kubernetes-preserve-unknown-fields: true
-              feedbackDisabled:
-                description: Disable feedback collection
+              feedbackEnabled:
+                default: true
+                description: Enable feedback collection
                 type: boolean
               llmAPIVersion:
                 description: LLM API Version for LLM providers that require it (e.g.,
@@ -171,8 +172,9 @@ spec:
               tlsCACertBundle:
                 description: Configmap name containing a CA Certificates bundle
                 type: string
-              transcriptsDisabled:
-                description: Disable conversation transcripts collection
+              transcriptsEnabled:
+                default: true
+                description: Enable conversation transcripts collection
                 type: boolean
             required:
             - llmCredentials

internal/controller/lcore_config.go

@@ -100,8 +100,8 @@ func buildLCoreLlamaStackConfig() map[string]interface{} {
 }
 
 func buildLCoreUserDataCollectionConfig(_ *common_helper.Helper, instance *apiv1beta1.OpenStackLightspeed) map[string]interface{} {
-	feedbackEnabled := !instance.Spec.FeedbackDisabled
-	transcriptsEnabled := !instance.Spec.TranscriptsDisabled
+	feedbackEnabled := instance.Spec.FeedbackEnabled == nil || *instance.Spec.FeedbackEnabled
+	transcriptsEnabled := instance.Spec.TranscriptsEnabled == nil || *instance.Spec.TranscriptsEnabled
 
 	return map[string]interface{}{
 		"feedback_enabled":    feedbackEnabled,
@@ -176,7 +176,7 @@ func buildLCoreConversationCacheConfig(h *common_helper.Helper, _ *apiv1beta1.Op
 
 // isDataCollectionEnabled returns true if at least one of feedback or transcripts is enabled.
 func isDataCollectionEnabled(instance *apiv1beta1.OpenStackLightspeed) bool {
-	return !instance.Spec.FeedbackDisabled || !instance.Spec.TranscriptsDisabled
+	return (instance.Spec.FeedbackEnabled == nil || *instance.Spec.FeedbackEnabled) || (instance.Spec.TranscriptsEnabled == nil || *instance.Spec.TranscriptsEnabled)
 }
 
 // buildExporterConfigMap creates the ConfigMap for the dataverse exporter sidecar.

test/kuttl/tests/update-openstacklightspeed/07-update-openstack-lightspeed-instance.yaml

@@ -28,8 +28,8 @@ spec:
   llmProjectID: test-project-id-UPDATE
   llmDeploymentName: test-deployment-name-UPDATE
   llmAPIVersion: v1.1
-  feedbackDisabled: true
-  transcriptsDisabled: true
+  feedbackEnabled: false
+  transcriptsEnabled: false
   logging:
     ogxLogLevel: "core=debug,providers=info"
     lightspeedStackLogLevel: ERROR

test/kuttl/tests/update-openstacklightspeed/08-assert-openstacklightspeed-update.yaml

@@ -271,8 +271,8 @@ spec:
   llmProjectID: test-project-id-UPDATE
   llmDeploymentName: test-deployment-name-UPDATE
   llmAPIVersion: v1.1
-  feedbackDisabled: true
-  transcriptsDisabled: true
+  feedbackEnabled: false
+  transcriptsEnabled: false
   logging:
     ogxLogLevel: "core=debug,providers=info"
     lightspeedStackLogLevel: ERROR