MCP: Liveness probe

Add a liveness probe on the rhos-mcp container.

This commit depends on the lightspeed-mcps PR #18 [1] that adds the
`/health` endpoint.

[1]: openstack-k8s-operators/lightspeed-mcps#18

Author: Akrog

internal/controller/assets/mcp_server_config.yaml.tmpl

@@ -1,5 +1,8 @@
 ---
-ip: 127.0.0.1
+# Bind to all interfaces so the kubelet liveness probe can reach /health.
+# This is safe: the container has no declared ports or Service, so nothing
+# routes external traffic to it.
+ip: 0.0.0.0
 port: 8080
 debug: false
 workers: 1

internal/controller/constants.go

@@ -118,6 +118,12 @@ const (
 	LightspeedStackStartupProbeFailureThreshold = int32(30)
 	LightspeedStackProbeFailureThreshold        = int32(3)
 
+	// Health probe settings for the rhoso-mcps container.
+	MCPServerHealthPath            = "/health"
+	MCPServerProbePeriodSeconds    = int32(10)
+	MCPServerProbeTimeoutSeconds   = int32(5)
+	MCPServerProbeFailureThreshold = int32(3)
+
 	// Data Exporter
 	ExporterConfigVolumeName       = "exporter-config"
 	ExporterConfigMountPath        = "/etc/config"

internal/controller/lcore_deployment.go

@@ -232,6 +232,17 @@ func buildLCorePodTemplateSpec(h *common_helper.Helper, ctx context.Context, ins
 					corev1.ResourceMemory: resource.MustParse("200Mi"),
 				},
 			},
+			LivenessProbe: &corev1.Probe{
+				ProbeHandler: corev1.ProbeHandler{
+					HTTPGet: &corev1.HTTPGetAction{
+						Path: MCPServerHealthPath,
+						Port: intstr.FromInt32(MCPServerPort),
+					},
+				},
+				PeriodSeconds:    MCPServerProbePeriodSeconds,
+				TimeoutSeconds:   MCPServerProbeTimeoutSeconds,
+				FailureThreshold: MCPServerProbeFailureThreshold,
+			},
 			ImagePullPolicy: corev1.PullIfNotPresent,
 		}
 		containers = append(containers, mcpContainer)

test/kuttl/tests/rhoso-mcps-configuration/05-assert-rhos-mcp-config-merged.yaml

@@ -37,7 +37,7 @@ commands:
 
       # Template defaults should be preserved
       assert_yaml_field "port" "8080"
-      assert_yaml_field "ip" "127.0.0.1"
+      assert_yaml_field "ip" "0.0.0.0"
       assert_yaml_field "openstack.ca_cert" "./tls-ca-bundle.pem"
       assert_yaml_field "openstack.insecure" "False"
       assert_yaml_field "openshift.insecure" "False"