Add input/output sanitization and security improvements - #24
Conversation
* Change operator logger from development to production mode to avoid leaking heavy stack traces that can contain internal information on warning+ log levels. Development logs can still be enabled using the --zap-devel argument. * Add RunAsNonRoot and drop all Linux capabilities on the Postgres container. * Add kubebuilder validation constraints: - URL pattern on LLMEndpoint - Format pattern on OGXLogLevel - minimum=1 on MaxTokensForResponse * Add HTTP security headers to the console plugin nginx config (X-Frame-Options, X-Content-Type-Options, Referrer-Policy) Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
|
/retest Unrelated error: "failed to wait for the created cluster claim to become ready: timed out waiting for the condition" |
|
/retest |
|
/retest failed to wait for the created cluster claim to become ready: timed out waiting for the condition |
|
/retest |
|
/retest This looks painful. We should figure out whether we can do something about it. I'm thinking we might be maybe requesting too much resources (?) idk. |
|
@lpiwowar yeah I think it's broken somehow, super painful. I just ran the kuttl tests again locally and everything is good. Yeah I will take a look at other projects and see if it's failing too, but as u said, maybe it's the amount of resource ? Idk |
lpiwowar
left a comment
There was a problem hiding this comment.
/lgtm
LGTM 👍 , let's see whether the jobs pass.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lpiwowar, umago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@umago: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
f3816ec
into
openstack-k8s-operators:main
Change operator logger from development to production mode to avoid leaking heavy stack traces that can contain internal information on warning+ log levels. Development logs can still be enabled using the --zap-devel argument [0].
Add RunAsNonRoot and drop all Linux capabilities on the Postgres container.
Add kubebuilder validation constraints:
Add HTTP security headers to the console plugin nginx config (X-Frame-Options, X-Content-Type-Options, Referrer-Policy)
[0] https://sdk.operatorframework.io/docs/building-operators/golang/references/logging/#setting-flags-when-running-locally