Remove unnecessary RBAC verbs from operator ClusterRole and Role - #26
Closed
lpiwowar wants to merge 1 commit into
Closed
Remove unnecessary RBAC verbs from operator ClusterRole and Role#26lpiwowar wants to merge 1 commit into
lpiwowar wants to merge 1 commit into
Conversation
Reduced permissions on three resources following the principle of least privilege: - openstacklightspeeds (ClusterRole): removed create, delete, update; get, list, watch, patch are sufficient for normal reconciliation - openstacklightspeeds/status (ClusterRole): removed get and update; only patch is needed to update status subresource - clusterserviceversions (namespaced Role): removed patch; only update and delete are needed for owner reference and uninstall Regenerated config/rbac/role.yaml and bundle manifests via make manifests && make bundle. Closes OSPRH-30842
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lpiwowar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes unnecessary RBAC verbs from the OpenStack Lightspeed operator to follow the principle of least privilege.
Changes
openstacklightspeeds(ClusterRole)create,delete,updateget,list,watch,patchopenstacklightspeeds/status(ClusterRole)get,updatepatchclusterserviceversions(namespaced Role)patchupdate,deleteThe source of truth is the kubebuilder RBAC markers in
internal/controller/openstacklightspeed_controller.go. Theconfig/rbac/role.yamland bundle manifests were regenerated viamake manifests && make bundle.Testing
make testpassesCloses OSPRH-30842