[golang] bump to golang 1.24#462
Conversation
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/477dd87e87f246f782eeaaeed05eef16 ❌ openstack-k8s-operators-content-provider TIMED_OUT in 31m 03s |
| type: string | ||
| type: object | ||
| required: | ||
| - databaseInstance |
There was a problem hiding this comment.
seems there was an issue with the older controller-tools version. the database Instance was required since beginning. In general I think it should not be a problem since envs with enabled manila must have a db instance. there may be an issue in an existing env where manila is set with enabled: false in the ctlplane cr, but the manila.template with content, but not having the databaseInstance.
+ /go/src/github.com/openstack-k8s-operators/operator/bin/crd-schema-checker check-manifests --disabled-validators NoMaps --disabled-validators NoBools --disabled-validators ListsMustHaveSSATags --existing-crd-filename=/tmp/tmp.ZAgdKMzOVd/config/crd/bases/manila.openstack.org_manilas.yaml --new-crd-filename=config/crd/bases/manila.openstack.org_manilas.yaml
ERROR: "NoNewRequiredFields": crd/manilas.manila.openstack.org version/v1beta1 field/^.spec.databaseInstance is new and may not be required
There was a problem hiding this comment.
It shouldn't be a problem and this field should be required for the CR itself. I think we saw an issue in the past due to these missing parameters when transitioning the service from enabled false to true. Maybe having this field as required in the CRD avoid us that issue at deployment time.
There was a problem hiding this comment.
just for the record, addressing this in #472 as a pre golang bump PR
There seems to be a bug in the current controller-gen version used, which resulted in the databaseInstance in manila not to be a required paramater. With the bump controller-gen happening as part of the golang-bump work the databaseInstance gets added as a required parameter [1]. This adds it to the ctlplane template. [1] openstack-k8s-operators/manila-operator#462 (comment) Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Add databaseInstance for manila in ctlplane template There seems to be a bug in the current controller-gen version used, which resulted in the databaseInstance in manila not to be a required paramater. With the bump controller-gen happening as part of the golang-bump work the databaseInstance gets added as a required parameter [1]. This adds it to the ctlplane template. [1] openstack-k8s-operators/manila-operator#462 (comment) Reviewed-by: Francesco Pantano <fpantano@redhat.com> Reviewed-by: Andrew Bays <andrew.bays@gmail.com>
* bump in go.mod (base and api)
* bump go-toolset in Dockerfile
* bump in github jobs ('.github/workflows')
* Bump the golangci-lint version in the .pre-commit-config.yaml to v2.4.0
* Bump build_root_image in .ci-operator.yaml to ci-build-root-golang-1.24-sdk-1.31
Also fixes golangci-lint reported issues for new v2.4.0 version.
Jira: OSPRH-12935
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Co-authored-by: Claude (Anthropic) claude@anthropic.com
Update controller-runtime, Kubernetes dependencies, and testing tools to support OpenShift Container Platform 4.18 (Kubernetes 1.31). Changes: - controller-runtime: v0.17.6 → v0.19.7 - Kubernetes core dependencies: v0.29.15 → v0.31.12 * k8s.io/api: v0.31.12 * k8s.io/apimachinery: v0.31.12 * k8s.io/client-go: v0.31.12 * k8s.io/apiextensions-apiserver: v0.31.12 - k8s.io/utils: v0.0.0-20240711033017 → v0.0.0-20250820121507 - controller-gen: v0.14.0 → v0.18.0 - envtest: 1.29 → 1.31, setup-envtest@latest Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
|
/test manila-operator-build-deploy-kuttl |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprince, fmount, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit ea6202c
into
openstack-k8s-operators:main
There seems to be a bug in the current controller-gen version used, which resulted in the databaseInstance in manila not to be a required paramater. With the bump controller-gen happening as part of the golang-bump work the databaseInstance gets added as a required parameter [1]. This adds it to the ctlplane template. [1] openstack-k8s-operators/manila-operator#462 (comment) Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
4 participants
Also bump dependencies for OpenShift 4.18. Update controller-runtime, Kubernetes dependencies, and testing tools to support OpenShift Container Platform 4.18 (Kubernetes 1.31):
To test on existing env, or after landed:
go.work*filesgo work initbin/subdir of the repoDepends-On: openstack-k8s-operators/install_yamls#1082
Depends-On: openstack-k8s-operators/openstack-operator#1567
Jira: OSPRH-12935