Align and remove omitempty from databaseInstance

[stuggi]

For adoption testing a ctlplane with disabled manila gets applied:

  manila:
    enabled: false
    template:
      manilaAPI: {}
      manilaScheduler: {}
      manilaShares: {}

This fails with because the manila databaseInstance parameter has omitempty specified:

$ oc apply -f ./test_deployment.yaml
The OpenStackControlPlane "openstack" is invalid:
* spec.manila.template.databaseInstance: Required value
* <nil>: Invalid value: "null": some validation rules were not checked because the object was invalid; correct the existing errors to complete validation

This aligns the databaseInstance parameter and removes the omitempty like it is speficied in all other service operators.

Depends-On: openstack-k8s-operators/openstack-operator#1610

Jira: OSPRH-12935

[stuggi]

seen in openstack-k8s-operators/openstack-operator#1567

[fmount]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [fmount,stuggi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fmount]

@stuggi I think we can override precommit-check because we know what we're doing here.

 gs --existing-crd-filename=/tmp/tmp.Hwdyfa8zhb/config/crd/bases/manila.openstack.org_manilas.yaml --new-crd-filename=config/crd/bases/manila.openstack.org_manilas.yaml
ERROR: "NoNewRequiredFields": crd/manilas.manila.openstack.org version/v1beta1 field/^.spec.databaseInstance is new and may not be required 

[stuggi]

@stuggi I think we can override precommit-check because we know what we're doing here.

 gs --existing-crd-filename=/tmp/tmp.Hwdyfa8zhb/config/crd/bases/manila.openstack.org_manilas.yaml --new-crd-filename=config/crd/bases/manila.openstack.org_manilas.yaml
ERROR: "NoNewRequiredFields": crd/manilas.manila.openstack.org version/v1beta1 field/^.spec.databaseInstance is new and may not be required 

yes I'll do that when the other tests passed.

[stuggi]

/test manila-operator-build-deploy-kuttl

[stuggi]

we need an openstack-operator bump to resolve the kuttl error ... openstack-k8s-operators/openstack-operator#1610

[stuggi]

lets see if the depends-on works

[stuggi]

/test manila-operator-build-deploy-kuttl

[stuggi]

/override ci/prow/precommit-check

[openshift-ci]

@stuggi: Overrode contexts on behalf of stuggi: ci/prow/precommit-check

Details

In response to this:

/override ci/prow/precommit-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.