Skip to content

Upgrade to Operator SDK 1.41.1#384

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
stuggi:operator_sdk_1.41.1
Nov 24, 2025
Merged

Upgrade to Operator SDK 1.41.1#384
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
stuggi:operator_sdk_1.41.1

Conversation

@stuggi

@stuggi stuggi commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

This commit upgrades the mariadb-operator to use Operator SDK version 1.41.1, with the following major changes:

Project Structure:

  • Move pkg/ packages to internal/ following Go best practices
  • Move controllers/ to internal/controller/ per new operator-sdk layout
  • Replace main.go with cmd/main.go
  • Add controller and webhook test suites

Configuration Updates:

  • Split certificate management into separate metrics and webhook certs
  • Add network policies for metrics and webhook traffic
  • Rename auth_proxy resources to metrics for clarity
  • Add admin RBAC roles for all CRD types
  • Update manager deployment configuration and patches
  • Modernize kustomization configurations

Webhook Changes:

  • Add dedicated webhook implementation in internal/webhook/v1beta1/
  • Remove old CRD webhook and CA injection patches
  • Update webhook manifests and service configuration

Cleanup:

  • Remove obsolete config patches and overlays

Dependencies:

  • Update go.mod and go.sum for operator-sdk 1.41.1 dependencies

Jira: OSPRH-22041

Assisted-by: claude-4-sonnet

Depends-On: openstack-k8s-operators/openstack-operator#1683
Depends-On: openstack-k8s-operators/install_yamls#1110

@stuggi

stuggi commented Nov 17, 2025

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@stuggi

stuggi commented Nov 18, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@stuggi stuggi force-pushed the operator_sdk_1.41.1 branch from 5631d72 to c072849 Compare November 19, 2025 14:55
@stuggi

stuggi commented Nov 19, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@abays

abays commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

We need to update the local webhook script (hack/run_with_local_webhook.sh) to use cmd/main.go: https://github.com/abays/ironic-operator/blob/34b64dbc8bd78b43401d36ee65cacbe1e63ef25a/hack/run_with_local_webhook.sh#L133

@stuggi

stuggi commented Nov 20, 2025

Copy link
Copy Markdown
Contributor Author

We need to update the local webhook script (hack/run_with_local_webhook.sh) to use cmd/main.go: https://github.com/abays/ironic-operator/blob/34b64dbc8bd78b43401d36ee65cacbe1e63ef25a/hack/run_with_local_webhook.sh#L133

good catch, thanks!

@stuggi stuggi force-pushed the operator_sdk_1.41.1 branch from c072849 to 85086d1 Compare November 20, 2025 10:48
@stuggi

stuggi commented Nov 20, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@stuggi stuggi force-pushed the operator_sdk_1.41.1 branch 3 times, most recently from 9dc47e7 to 8943e05 Compare November 21, 2025 12:58
This commit upgrades the mariadb-operator to use Operator SDK version 1.41.1,
with the following major changes:

Project Structure:
- Move pkg/ packages to internal/ following Go best practices
- Move controllers/ to internal/controller/ per new operator-sdk layout
- Replace main.go with cmd/main.go
- Add controller and webhook test suites

Configuration Updates:
- Split certificate management into separate metrics and webhook certs
- Add network policies for metrics and webhook traffic
- Rename auth_proxy resources to metrics for clarity
- Add admin RBAC roles for all CRD types
- Update manager deployment configuration and patches
- Modernize kustomization configurations

Webhook Changes:
- Add dedicated webhook implementation in internal/webhook/v1beta1/
- Remove old CRD webhook and CA injection patches
- Update webhook manifests and service configuration

Cleanup:
- Remove obsolete config patches and overlays

Dependencies:
- Update go.mod and go.sum for operator-sdk 1.41.1 dependencies

Jira: OSPRH-22041

Assisted-by: claude-4-sonnet
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Comment thread Makefile
for mod in $(shell find . -name go.mod -exec dirname {} \;); do \
pushd ./$$mod ; \
if [ -f test/functional/suite_test.go ]; then \
KUBEBUILDER_ASSETS="$(shell $(ENVTEST) -v debug --bin-dir $(LOCALBIN) use $(ENVTEST_K8S_VERSION) -p path)" $(GINKGO) --trace --cover --coverprofile cover.out --covermode=atomic --coverpkg=../../pkg/mariadb,../../controllers,../../api/v1beta1 ${PROC_CMD} $(GINKGO_ARGS) ./test/... || exit 1; \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update any of the paths here?

@abays abays Nov 24, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The respective dirs that would be a problem (the ones that changed locations) have no tests in them. So I don't think these really matter. We should still clean it up, but we can do it in a follow-up.

@abays abays left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit f08eaf8 into openstack-k8s-operators:main Nov 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants