Add input validation for MariaDBAccount and MariaDBDatabase CR fields#483
Merged
openshift-merge-bot[bot] merged 1 commit intoJun 24, 2026
Conversation
Add kubebuilder:validation:Pattern and MaxLength constraints to MariaDBAccount.spec.userName and MariaDBDatabase.spec.name, .defaultCharacterSet, .defaultCollation fields. These fields are rendered into SQL statements and shell commands via Go text/template without escaping. While K8s metadata validation currently prevents most injection characters (the field values flow into Job names and labels), adding explicit CRD-level validation makes the protection intentional rather than accidental. The pattern ^[a-zA-Z0-9_]+$ matches all valid MySQL identifiers and all values currently used by consuming operators (keystone, nova, glance, cinder, nova_cell0, etc.). Jira: OSPRH-31719 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
dciabrin
approved these changes
Jun 24, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dciabrin, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 1bf8617
into
openstack-k8s-operators:main
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add kubebuilder:validation:Pattern and MaxLength constraints to MariaDBAccount.spec.userName and MariaDBDatabase.spec.name, .defaultCharacterSet, .defaultCollation fields.
These fields are rendered into SQL statements and shell commands via Go text/template without escaping. While K8s metadata validation currently prevents most injection characters (the field values flow into Job names and labels), adding explicit CRD-level validation makes the protection intentional rather than accidental.
The pattern ^[a-zA-Z0-9_]+$ matches all valid MySQL identifiers and all values currently used by consuming operators (keystone, nova, glance, cinder, nova_cell0, etc.).
Jira: OSPRH-31719