Add application credential finalizer management

[Deydra71]

Jira: OSPRH-29269

Application Credential dev-doc: https://github.com/openstack-k8s-operators/dev-docs/blob/main/application_credentials.md

• Tracks the active AC secret name in Status.ApplicationCredentialSecret
• Add openstack.org/neutronapi-ac-consumer finalizer to the AC secret after service config is rendered
• On AC rotation, move the finalizer from the old secret to the new one
• On CR deletion, remove the consumer finalizer from the AC secret before cleaning up the CR

This ensures that the keystone-operator cannot revoke a rotated AC secret while Neutron is still consuming it.

2026-04-28T11:54:58.578Z	INFO	Controllers.NeutronAPI	Added consumer finalizer	{"controller": "neutronapi", "controllerGroup": "neutron.openstack.org", "controllerKind": "NeutronAPI", "NeutronAPI": {"name":"neutron","namespace":"openstack"}, "namespace": "openstack", "name": "neutron", "reconcileID": "c8bf38d1-2f9c-4fe9-88ba-1f6f2a701983", "object": "ac-neutron-0dc46-secret", "finalizer": "openstack.org/neutronapi-ac-consumer"}
2026-04-28T11:54:58.589Z	INFO	Controllers.NeutronAPI	Removed consumer finalizer	{"controller": "neutronapi", "controllerGroup": "neutron.openstack.org", "controllerKind": "NeutronAPI", "NeutronAPI": {"name":"neutron","namespace":"openstack"}, "namespace": "openstack", "name": "neutron", "reconcileID": "c8bf38d1-2f9c-4fe9-88ba-1f6f2a701983", "object": "ac-neutron-86ca8-secret", "finalizer": "openstack.org/neutronapi-ac-consumer"}

Depends-On: openstack-k8s-operators/keystone-operator#685

Assisted-by: Claude Opus 4.6 noreply@anthropic.com

[softwarefactory-project-zuul]

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/neutron-operator for 618,67833c8a7a98b29abef2ace6c6d5aed56e50093c

[softwarefactory-project-zuul]

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/neutron-operator for 618,05c20c1d6ccd5dd2ba8fccaef23fcbb68a9883b7

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/37b8d376ac0d49d4bd3759b88db8053b

❌ openstack-k8s-operators-content-provider FAILURE in 10m 37s
⚠️ neutron-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/63ec2a4ca5d048f9add5f9999ff5af7c

❌ openstack-k8s-operators-content-provider FAILURE in 10m 53s
⚠️ neutron-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

[centosinfra-prod-github-app]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/b2418d6612b04aed86f54ae10cac6b5c

❌ openstack-k8s-operators-content-provider FAILURE in 4m 03s
⚠️ neutron-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

[Deydra71]

recheck

[Deydra71]

Following the discussion in watcher-operator the AC finalizer management is now split into two phases:

• Early phase: adds consumer finalizer to the new AC secret immediately (protects it from premature revocation)
• Late phase: removes consumer finalizer from the old AC secret only after AllSubConditionIsTrue() (all sub-services deployed with new credentials)

This prevents a race condition where rapid AC rotations could revoke credentials still in use by running pods.

[Deydra71]

/test neutron-operator-build-deploy-kuttl

Looks like an env/timing hiccup

[fmount]

/lgtm

[fmount]

the implementation is in line with all the other (merged) patches. @slawqo @karelyatin to check and push a final approve.

[Deydra71]

/test neutron-operator-build-deploy-kuttl

[centosinfra-prod-github-app]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/12def49513904f70b85cc8cacbf8438a

✔️ openstack-k8s-operators-content-provider SUCCESS in 49m 39s
❌ neutron-operator-tempest-multinode POST_FAILURE in 22m 40s

[fmount]

recheck

[fmount]

/retest

[centosinfra-prod-github-app]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/d8db1b1a77cb45d696bc3068db0a12bf

❌ openstack-k8s-operators-content-provider FAILURE in 6m 40s
⚠️ neutron-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

[Deydra71]

recheck

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Deydra71, fmount, slawqo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [slawqo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment