Adds notification transporturl

Author: auniyal61

api/v1beta1/conditions.go

@@ -52,6 +52,10 @@ const (
 	NovaComputeServiceConfigReady condition.Type = "NovaComputeServiceConfigReady"
 	// NovaAllControlPlaneComputesReadyCondition indicates that every defined NovaCompute is ready but undiscovered
 	NovaAllControlPlaneComputesReadyCondition condition.Type = "NovaAllControlPlaneComputesReady"
+
+	// notifications
+	// NovaNotificationMQReadyCondition indicated that the top level notification message bus is ready
+	NovaNotificationMQReadyCondition condition.Type = "NovaNotificationMQReady"
 )
 
 // Common Messages used by API objects.
@@ -172,4 +176,14 @@ const (
 
 	//CellHostDiscoverErrorMessage
 	CellHostDiscoverErrorMessage = "CellHostDiscover error occurred %s"
+
+	// notifications
+	// NovaNotificationMQReadyErrorMessage
+	NovaNotificationMQReadyErrorMessage = "Notification message bus creation failed: %s"
+
+	// NovaNotificationMQReadyCreatingMessage
+	NovaNotificationMQReadyCreatingMessage = "Notification message bus creation ongoing"
+
+	// NovaNotificationMQReadyMessage
+	NovaNotificationMQReadyMessage = "Notification message bus creation successfully"
 )

controllers/nova_controller.go

@@ -233,6 +233,8 @@ func (r *NovaReconciler) Reconcile(ctx context.Context, req ctrl.Request) (resul
 		mariadbv1.MariaDBAccountReadyMessage,
 	)
 
+	Log.Info("", ":", "t-url-instance", ":", instance.Spec)
+
 	// There is a webhook validation that ensures that there is always cell0 in
 	// the cellTemplates
 	cell0Template := instance.Spec.CellTemplates[novav1.Cell0Name]
@@ -384,6 +386,50 @@ func (r *NovaReconciler) Reconcile(ctx context.Context, req ctrl.Request) (resul
 		return ctrl.Result{}, fmt.Errorf("%w from  for the API MQ: %d", util.ErrInvalidStatus, apiMQStatus)
 	}
 
+	// look at transport url state/condition - spec
+	// from spec which rabbit mq, and state of that rabbitmq
+	// if aboce ois good
+	// debug ensureMQ
+	//
+
+	// nova broadcaster rabbit
+	notificationBusName := ""
+	if instance.Spec.NotificationsBusInstance != nil {
+		notificationBusName = *instance.Spec.NotificationsBusInstance
+	}
+
+	notificationTransportURL, notificationMQStatus, notificationMQError := r.ensureMQ(
+		ctx, h, instance, instance.Name+"-notification-transport", notificationBusName)
+
+	// switch notificationMQStatus {
+	// case nova.MQFailed:
+	// 	instance.Status.Conditions.Set(condition.FalseCondition(
+	// 		novav1.NovaNotificationMQReadyCondition,
+	// 		condition.ErrorReason,
+	// 		condition.SeverityError,
+	// 		novav1.NovaNotificationMQReadyErrorMessage,
+	// 		notificationMQError.Error(),
+	// 	))
+	// case nova.MQCreating:
+	// 	instance.Status.Conditions.Set(condition.FalseCondition(
+	// 		novav1.NovaNotificationMQReadyCondition,
+	// 		condition.ErrorReason,
+	// 		condition.SeverityError,
+	// 		novav1.NovaNotificationMQReadyCreatingMessage,
+	// 	))
+	// case nova.MQCompleted:
+	// 	instance.Status.Conditions.MarkTrue(
+	// 		novav1.NovaNotificationMQReadyCondition, novav1.NovaNotificationMQReadyMessage)
+	// default:
+	// 	return ctrl.Result{}, fmt.Errorf("%w from  for the Notification MQ: %d",
+	// 		util.ErrInvalidStatus, notificationMQStatus)
+	// }
+
+	Log.Info("", "t-url-url", notificationTransportURL)
+
+	Log.Info("", "t-url-status", notificationMQStatus)
+	Log.Info("", "t-url-err", notificationMQError)
+
 	cellMQs := map[string]*nova.MessageBus{}
 	var failedMQs []string
 	var creatingMQs []string
@@ -1625,6 +1671,7 @@ func (r *NovaReconciler) ensureMQ(
 	})
 
 	if err != nil && !k8s_errors.IsNotFound(err) {
+		Log.Info("", ":", "t-url-1")
 		return "", nova.MQFailed, util.WrapErrorForObject(
 			fmt.Sprintf("Error create or update TransportURL object %s", transportName),
 			transportURL,
@@ -1633,12 +1680,14 @@ func (r *NovaReconciler) ensureMQ(
 	}
 
 	if op != controllerutil.OperationResultNone {
+		Log.Info("", ":", "t-url-2")
 		Log.Info(fmt.Sprintf("TransportURL object %s created or patched", transportName))
 		return "", nova.MQCreating, nil
 	}
 
 	err = r.Client.Get(ctx, types.NamespacedName{Namespace: instance.Namespace, Name: transportName}, transportURL)
 	if err != nil && !k8s_errors.IsNotFound(err) {
+		Log.Info("", ":", "t-url-3")
 		return "", nova.MQFailed, util.WrapErrorForObject(
 			fmt.Sprintf("Error reading TransportURL object %s", transportName),
 			transportURL,
@@ -1647,13 +1696,16 @@ func (r *NovaReconciler) ensureMQ(
 	}
 
 	if k8s_errors.IsNotFound(err) || !transportURL.IsReady() || transportURL.Status.SecretName == "" {
+		Log.Info("", ":", "t-url-4", "", transportURL)
+		Log.Info("", ":", "t-url-4", "", transportURL.Status)
 		return "", nova.MQCreating, nil
 	}
 
 	secretName := types.NamespacedName{Namespace: instance.Namespace, Name: transportURL.Status.SecretName}
 	secret := &corev1.Secret{}
 	err = h.GetClient().Get(ctx, secretName, secret)
 	if err != nil {
+		Log.Info("", ":", "t-url-5")
 		if k8s_errors.IsNotFound(err) {
 			return "", nova.MQCreating, nil
 		}
@@ -1662,6 +1714,7 @@ func (r *NovaReconciler) ensureMQ(
 
 	url, ok := secret.Data[TransportURLSelector]
 	if !ok {
+		Log.Info("", ":", "t-url-6")
 		return "", nova.MQFailed, fmt.Errorf(
 			"%w: the TransportURL secret %s does not have 'transport_url' field", util.ErrFieldNotFound, transportURL.Status.SecretName)
 	}