cyborg: Implement CyborgConductor controller reconcile loop

Add full reconcile logic for the CyborgConductor CR:
- Validate input from the config secret created by the Cyborg controller
- Generate conductor config from templates (00-default.conf)
- Create a StatefulSet to run cyborg-conductor pods
- Track readiness (ReadyCount, conditions, hash, topology)
- Expose IsReady and topology helpers on CyborgConductor type
- Update CyborgConductorStatus with structured conditions and hash
- Extend Cyborg controller to propagate conductor and check readiness upwards
- Add functional tests for the conductor reconcile loop

Assisted-By: Claude
Signed-off-by: Alfredo Moralejo <amoralej@redhat.com>

Author: amoralej

api/bases/cyborg.openstack.org_cyborgconductors.yaml

@@ -14,7 +14,16 @@ spec:
     singular: cyborgconductor
   scope: Namespaced
   versions:
-  - name: v1beta1
+  - additionalPrinterColumns:
+    - description: Status
+      jsonPath: .status.conditions[0].status
+      name: Status
+      type: string
+    - description: Message
+      jsonPath: .status.conditions[0].message
+      name: Message
+      type: string
+    name: v1beta1
     schema:
       openAPIV3Schema:
         description: CyborgConductor is the Schema for the cyborgconductors API.
@@ -40,8 +49,12 @@ spec:
             description: CyborgConductorSpec defines the desired state of CyborgConductor.
             properties:
               configSecret:
-                description: ConfigSecret - containing all the configuration needed
-                  provided by Cyborg object
+                description: |-
+                  Secret is the name of the sub-level secret containing all required data
+                  (transport URL, DB creds, keystone auth, service password, etc.)
+                type: string
+              containerImage:
+                description: ContainerImage is the container image URL for cyborg-conductor
                 type: string
               customServiceConfig:
                 description: |-
@@ -124,6 +137,17 @@ spec:
                       More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
                     type: object
                 type: object
+              serviceAccount:
+                description: ServiceAccount used by the conductor pods
+                type: string
+              tls:
+                description: TLS - Parameters related to the TLS
+                properties:
+                  caBundleSecretName:
+                    description: CaBundleSecretName - holding the CA certs in a pre-created
+                      bundle file
+                    type: string
+                type: object
               topologyRef:
                 description: |-
                   TopologyRef to apply the Topology defined by the associated CR referenced
@@ -143,9 +167,82 @@ spec:
                 type: object
             required:
             - configSecret
+            - containerImage
+            - serviceAccount
             type: object
           status:
             description: CyborgConductorStatus defines the observed state of CyborgConductor.
+            properties:
+              conditions:
+                description: Conditions
+                items:
+                  description: Condition defines an observation of a API resource
+                    operational state.
+                  properties:
+                    lastTransitionTime:
+                      description: |-
+                        Last time the condition transitioned from one status to another.
+                        This should be when the underlying condition changed. If that is not known, then using the time when
+                        the API field changed is acceptable.
+                      format: date-time
+                      type: string
+                    message:
+                      description: A human readable message indicating details about
+                        the transition.
+                      type: string
+                    reason:
+                      description: The reason for the condition's last transition
+                        in CamelCase.
+                      type: string
+                    severity:
+                      description: |-
+                        Severity provides a classification of Reason code, so the current situation is immediately
+                        understandable and could act accordingly.
+                        It is meant for situations where Status=False and it should be indicated if it is just
+                        informational, warning (next reconciliation might fix it) or an error (e.g. DB create issue
+                        and no actions to automatically resolve the issue can/should be done).
+                        For conditions where Status=Unknown or Status=True the Severity should be SeverityNone.
+                      type: string
+                    status:
+                      description: Status of the condition, one of True, False, Unknown.
+                      type: string
+                    type:
+                      description: Type of condition in CamelCase.
+                      type: string
+                  required:
+                  - lastTransitionTime
+                  - status
+                  - type
+                  type: object
+                type: array
+              hash:
+                additionalProperties:
+                  type: string
+                description: Hash - Map of hashes to track config changes
+                type: object
+              lastAppliedTopology:
+                description: LastAppliedTopology - the last applied Topology
+                properties:
+                  name:
+                    description: Name - The Topology CR name that the Service references
+                    type: string
+                  namespace:
+                    description: |-
+                      Namespace - The Namespace to fetch the Topology CR referenced
+                      NOTE: Namespace currently points by default to the same namespace where
+                      the Service is deployed. Customizing the namespace is not supported and
+                      webhooks prevent editing this field to a value different from the
+                      current project
+                    type: string
+                type: object
+              observedGeneration:
+                description: ObservedGeneration - the most recent generation observed
+                format: int64
+                type: integer
+              readyCount:
+                description: ReadyCount defines the number of replicas ready
+                format: int32
+                type: integer
             type: object
         type: object
     served: true

api/cyborg/v1beta1/conditions.go

@@ -50,6 +50,9 @@ const (
 	// CyborgConductorReadyInitMessage -
 	CyborgConductorReadyInitMessage = "CyborgConductor not started"
 
+	// CyborgConductorReadyErrorMessage -
+	CyborgConductorReadyErrorMessage = "CyborgConductor error occurred %s"
+
 	// CyborgApplicationCredentialSecretErrorMessage -
 	CyborgApplicationCredentialSecretErrorMessage = "Error with application credential secret"
 )

api/cyborg/v1beta1/cyborgconductor_types.go

@@ -18,13 +18,12 @@ package v1beta1
 
 import (
 	topologyv1 "github.com/openstack-k8s-operators/infra-operator/apis/topology/v1beta1"
+	"github.com/openstack-k8s-operators/lib-common/modules/common/condition"
+	"github.com/openstack-k8s-operators/lib-common/modules/common/tls"
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
-// EDIT THIS FILE!  THIS IS SCAFFOLDING FOR YOU TO OWN!
-// NOTE: json tags are required.  Any new fields you add must have json tags for the fields to be serialized.
-
 // CyborgConductorTemplate defines the input parameters specified by the user to
 // create a CyborgConductor via higher level CRDs.
 type CyborgConductorTemplate struct {
@@ -59,24 +58,49 @@ type CyborgConductorTemplate struct {
 
 // CyborgConductorSpec defines the desired state of CyborgConductor.
 type CyborgConductorSpec struct {
-	// INSERT ADDITIONAL SPEC FIELDS - desired state of cluster
-	// Important: Run "make" to regenerate code after modifying this file
-
 	CyborgConductorTemplate `json:",inline"`
 
 	// +kubebuilder:validation:Required
-	// ConfigSecret - containing all the configuration needed provided by Cyborg object
+	// Secret is the name of the sub-level secret containing all required data
+	// (transport URL, DB creds, keystone auth, service password, etc.)
 	ConfigSecret string `json:"configSecret"`
+
+	// +kubebuilder:validation:Required
+	// ContainerImage is the container image URL for cyborg-conductor
+	ContainerImage string `json:"containerImage"`
+
+	// +kubebuilder:validation:Required
+	// ServiceAccount used by the conductor pods
+	ServiceAccount string `json:"serviceAccount"`
+
+	// +kubebuilder:validation:Optional
+	// +operator-sdk:csv:customresourcedefinitions:type=spec
+	// TLS - Parameters related to the TLS
+	TLS tls.Ca `json:"tls,omitempty"`
 }
 
 // CyborgConductorStatus defines the observed state of CyborgConductor.
 type CyborgConductorStatus struct {
-	// INSERT ADDITIONAL STATUS FIELD - define observed state of cluster
-	// Important: Run "make" to regenerate code after modifying this file
+	// ReadyCount defines the number of replicas ready
+	ReadyCount int32 `json:"readyCount,omitempty"`
+
+	// Conditions
+	Conditions condition.Conditions `json:"conditions,omitempty" optional:"true"`
+
+	// ObservedGeneration - the most recent generation observed
+	ObservedGeneration int64 `json:"observedGeneration,omitempty"`
+
+	// Hash - Map of hashes to track config changes
+	Hash map[string]string `json:"hash,omitempty"`
+
+	// LastAppliedTopology - the last applied Topology
+	LastAppliedTopology *topologyv1.TopoRef `json:"lastAppliedTopology,omitempty"`
 }
 
 // +kubebuilder:object:root=true
 // +kubebuilder:subresource:status
+// +kubebuilder:printcolumn:name="Status",type="string",JSONPath=".status.conditions[0].status",description="Status"
+// +kubebuilder:printcolumn:name="Message",type="string",JSONPath=".status.conditions[0].message",description="Message"
 
 // CyborgConductor is the Schema for the cyborgconductors API.
 type CyborgConductor struct {
@@ -96,6 +120,26 @@ type CyborgConductorList struct {
 	Items           []CyborgConductor `json:"items"`
 }
 
+// IsReady returns true if the ReadyCondition is true
+func (instance *CyborgConductor) IsReady() bool {
+	return instance.Status.Conditions.IsTrue(condition.ReadyCondition)
+}
+
+// GetSpecTopologyRef returns the TopologyRef defined in the Spec
+func (instance *CyborgConductor) GetSpecTopologyRef() *topologyv1.TopoRef {
+	return instance.Spec.TopologyRef
+}
+
+// GetLastAppliedTopology returns the LastAppliedTopology from the Status
+func (instance *CyborgConductor) GetLastAppliedTopology() *topologyv1.TopoRef {
+	return instance.Status.LastAppliedTopology
+}
+
+// SetLastAppliedTopology sets the LastAppliedTopology value in the Status
+func (instance *CyborgConductor) SetLastAppliedTopology(topologyRef *topologyv1.TopoRef) {
+	instance.Status.LastAppliedTopology = topologyRef
+}
+
 func init() {
 	SchemeBuilder.Register(&CyborgConductor{}, &CyborgConductorList{})
 }