Skip to content

Commit ccf3672

Browse files
ratailoropenshift-merge-bot[bot]
authored andcommitted
test: Fix race condition in NovaNoVNCProxy topology test
The "updates lastAppliedTopology in NovaNoVNCProxy .Status" test was failing intermittently due to a race condition in test setup. **Problem**: SimulateMemcachedReady() was called after CreateNovaNoVNCProxy(), causing the controller's ensureMemcached() call to fail intermittently when reconciliation triggered before the Memcached instance was simulated as ready. **Solution**: Move SimulateMemcachedReady() call before CreateNovaNoVNCProxy() to ensure Memcached is ready before controller reconciliation begins. Commit-message-assisted-by: claude-4-sonnet Closes: OSPRH-19625
1 parent 3d3857d commit ccf3672

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

test/functional/nova_novncproxy_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1366,10 +1366,10 @@ var _ = Describe("NovaNoVNCProxy controller", func() {
13661366

13671367
memcachedSpec := infra.GetDefaultMemcachedSpec()
13681368
DeferCleanup(infra.DeleteMemcached, infra.CreateMemcached(novaNames.NovaName.Namespace, MemcachedInstance, memcachedSpec))
1369+
infra.SimulateMemcachedReady(novaNames.MemcachedNamespace)
13691370
DeferCleanup(th.DeleteInstance, CreateNovaNoVNCProxy(cell1.NoVNCProxyName, spec))
13701371
DeferCleanup(
13711372
k8sClient.Delete, ctx, CreateDefaultCellInternalSecret(cell1))
1372-
infra.SimulateMemcachedReady(novaNames.MemcachedNamespace)
13731373
})
13741374
It("sets lastAppliedTopology field in NovaNoVNCProxy topology .Status", func() {
13751375
th.SimulateStatefulSetReplicaReady(cell1.NoVNCProxyStatefulSetName)

0 commit comments

Comments
 (0)