Add permissions and branch protection validation to release workflow#167
Open
stuggi wants to merge 1 commit into
Open
Add permissions and branch protection validation to release workflow#167stuggi wants to merge 1 commit into
stuggi wants to merge 1 commit into
Conversation
Add pre-flight checks to validate GitHub App has required permissions and detect branch protection rules before creating release branches. Changes: - Add get_repos_list() function to eliminate code duplication - Add new step to check contents:write and pull_requests:write permissions - Validate against branch protection rules and repository rulesets - Detect patterns that might block new branch creation (e.g., 18.0-*) - Fail fast on permission errors, warn on protection rule matches - Run checks in both DRY_RUN and production modes Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
Why do we need to pre-check permissions like this? Can't we just try the workflow and let it fail if needed? |
Contributor
Author
yes, we could do that. the pre check would allow it to test it in advance running the workflow in test mode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pre-flight checks to validate GitHub App has required permissions and detect branch protection rules before creating release branches.
Changes: