ironic.go

package openstack

import (
	"context"
	"fmt"

	"github.com/openstack-k8s-operators/lib-common/modules/common/condition"
	"github.com/openstack-k8s-operators/lib-common/modules/common/helper"
	"github.com/openstack-k8s-operators/lib-common/modules/common/service"

	"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"

	ironicv1 "github.com/openstack-k8s-operators/ironic-operator/api/v1beta1"
	corev1beta1 "github.com/openstack-k8s-operators/openstack-operator/api/core/v1beta1"
	k8s_errors "k8s.io/apimachinery/pkg/api/errors"
	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
	"k8s.io/apimachinery/pkg/types"
	ctrl "sigs.k8s.io/controller-runtime"
)

// ReconcileIronic -
func ReconcileIronic(ctx context.Context, instance *corev1beta1.OpenStackControlPlane, version *corev1beta1.OpenStackVersion, helper *helper.Helper) (ctrl.Result, error) {
	ironic := &ironicv1.Ironic{
		ObjectMeta: metav1.ObjectMeta{
			Name:      "ironic",
			Namespace: instance.Namespace,
		},
	}
	Log := GetLogger(ctx)

	if !instance.Spec.Ironic.Enabled {
		if res, err := EnsureDeleted(ctx, helper, ironic); err != nil {
			return res, err
		}
		instance.Status.Conditions.Remove(corev1beta1.OpenStackControlPlaneIronicReadyCondition)
		instance.Status.Conditions.Remove(corev1beta1.OpenStackControlPlaneExposeIronicReadyCondition)
		instance.Status.ContainerImages.IronicAPIImage = nil
		instance.Status.ContainerImages.IronicConductorImage = nil
		instance.Status.ContainerImages.IronicInspectorImage = nil
		instance.Status.ContainerImages.IronicNeutronAgentImage = nil
		instance.Status.ContainerImages.IronicPxeImage = nil
		instance.Status.ContainerImages.IronicPythonAgentImage = nil
		// Clean up AC CRs when service is disabled (ironic has two: ironic and ironic-inspector)
		if err := CleanupApplicationCredentialForService(ctx, helper, instance, ironic.Name); err != nil {
			return ctrl.Result{}, err
		}
		if err := CleanupApplicationCredentialForService(ctx, helper, instance, "ironic-inspector"); err != nil {
			return ctrl.Result{}, err
		}
		return ctrl.Result{}, nil
	}

	if instance.Spec.Ironic.Template == nil {
		instance.Spec.Ironic.Template = &ironicv1.IronicSpecCore{}
	}

	// Note: Migration from rabbitMqClusterName to messagingBus.cluster is handled by the webhook
	// via annotation-based triggers. No direct spec mutation here to avoid GitOps conflicts.
	// This applies to both Ironic main template and IronicNeutronAgent.

	if instance.Spec.Ironic.Template.NodeSelector == nil && len(instance.Spec.NodeSelector) > 0 {
		instance.Spec.Ironic.Template.NodeSelector = &instance.Spec.NodeSelector
	}

	// When there's no Topology referenced in the Service Template, inject the
	// top-level one
	// NOTE: This does not check the Service subCRs: by default the generated
	// subCRs inherit the top-level TopologyRef unless an override is present
	if instance.Spec.Ironic.Template.TopologyRef == nil {
		instance.Spec.Ironic.Template.TopologyRef = instance.Spec.TopologyRef
	}

	// Propagate MessagingBus from top-level to template if not set
	// Template-level takes precedence over top-level
	if instance.Spec.MessagingBus != nil && instance.Spec.MessagingBus.Cluster != "" {
		if instance.Spec.Ironic.Template.MessagingBus.Cluster == "" {
			instance.Spec.Ironic.Template.MessagingBus = *instance.Spec.MessagingBus
		}
	}

	// Propagate MessagingBus to IronicNeutronAgent if not set
	// IronicNeutronAgent inherits from Ironic service-level if not set
	if instance.Spec.Ironic.Template.MessagingBus.Cluster != "" {
		if instance.Spec.Ironic.Template.IronicNeutronAgent.MessagingBus.Cluster == "" {
			instance.Spec.Ironic.Template.IronicNeutronAgent.MessagingBus = instance.Spec.Ironic.Template.MessagingBus
		}
	}

	// add selector to service overrides
	for _, endpointType := range []service.Endpoint{service.EndpointPublic, service.EndpointInternal} {
		if instance.Spec.Ironic.Template.IronicAPI.Override.Service == nil {
			instance.Spec.Ironic.Template.IronicAPI.Override.Service = map[service.Endpoint]service.RoutedOverrideSpec{}
		}
		instance.Spec.Ironic.Template.IronicAPI.Override.Service[endpointType] =
			AddServiceOpenStackOperatorLabel(
				instance.Spec.Ironic.Template.IronicAPI.Override.Service[endpointType],
				ironic.Name+"-api")

		if instance.Spec.Ironic.Template.IronicInspector.Override.Service == nil {
			instance.Spec.Ironic.Template.IronicInspector.Override.Service = map[service.Endpoint]service.RoutedOverrideSpec{}
		}
		instance.Spec.Ironic.Template.IronicInspector.Override.Service[endpointType] =
			AddServiceOpenStackOperatorLabel(
				instance.Spec.Ironic.Template.IronicInspector.Override.Service[endpointType],
				ironic.Name+"-inspector")
	}

	// When component services got created check if there is the need to create a route
	if err := helper.GetClient().Get(ctx, types.NamespacedName{Name: "ironic", Namespace: instance.Namespace}, ironic); err != nil {
		if !k8s_errors.IsNotFound(err) {
			return ctrl.Result{}, err
		}
	}

	// preserve any previously set TLS certs,set CA cert
	if instance.Spec.TLS.PodLevel.Enabled {
		instance.Spec.Ironic.Template.IronicAPI.TLS = ironic.Spec.IronicAPI.TLS
		instance.Spec.Ironic.Template.IronicInspector.TLS = ironic.Spec.IronicInspector.TLS
	}
	instance.Spec.Ironic.Template.IronicAPI.TLS.CaBundleSecretName = instance.Status.TLS.CaBundleSecretName
	instance.Spec.Ironic.Template.IronicInspector.TLS.CaBundleSecretName = instance.Status.TLS.CaBundleSecretName

	// Application Credential Management (Day-2 operation)
	// Ironic has 2 users: ironic (main service) and ironic-inspector
	ironicReady := ironic.Status.Conditions != nil && ironic.Status.ObservedGeneration == ironic.Generation && ironic.IsReady()

	// Apply same fallback logic as in CreateOrPatch to avoid passing empty values to AC
	// Both ironic and ironic-inspector share the same secret
	ironicSecret := instance.Spec.Ironic.Template.Secret
	if ironicSecret == "" {
		ironicSecret = instance.Spec.Secret
	}

	// Always reconcile AC - EnsureApplicationCredentialForService checks cluster state and handles the full AC lifecycle.
	if instance.Spec.Ironic.ApplicationCredential != nil ||
		instance.Spec.Ironic.Template.Auth.ApplicationCredentialSecret != "" ||
		instance.Spec.Ironic.Template.IronicInspector.Auth.ApplicationCredentialSecret != "" {

		// AC for main ironic service
		ironicACSecretName, acResult, err := EnsureApplicationCredentialForService(
			ctx,
			helper,
			instance,
			ironic.Name,
			ironicReady,
			ironicSecret,
			instance.Spec.Ironic.Template.PasswordSelectors.Service,
			instance.Spec.Ironic.Template.ServiceUser,
			instance.Spec.Ironic.ApplicationCredential,
		)
		if err != nil {
			return ctrl.Result{}, err
		}

		// If AC is not ready, return immediately without updating the service CR
		if (acResult != ctrl.Result{}) {
			return acResult, nil
		}

		// Set ApplicationCredentialSecret for main ironic service based on what the helper returned:
		// - If AC disabled: returns ""
		// - If AC enabled and ready: returns the AC secret name
		instance.Spec.Ironic.Template.Auth.ApplicationCredentialSecret = ironicACSecretName

		// AC for ironic-inspector (separate user, separate AC, but shares the same secret as ironic)
		inspectorACSecretName, inspectorACResult, err := EnsureApplicationCredentialForService(
			ctx,
			helper,
			instance,
			"ironic-inspector",
			ironicReady,
			ironicSecret, // Inspector shares the same secret as ironic
			instance.Spec.Ironic.Template.IronicInspector.PasswordSelectors.Service,
			instance.Spec.Ironic.Template.IronicInspector.ServiceUser,
			instance.Spec.Ironic.ApplicationCredential,
		)
		if err != nil {
			return ctrl.Result{}, err
		}

		// If AC is not ready, return immediately without updating the service CR
		if (inspectorACResult != ctrl.Result{}) {
			return inspectorACResult, nil
		}

		// Set ApplicationCredentialSecret for ironic-inspector based on what the helper returned:
		// - If AC disabled: returns ""
		// - If AC enabled and ready: returns the AC secret name
		instance.Spec.Ironic.Template.IronicInspector.Auth.ApplicationCredentialSecret = inspectorACSecretName
	}

	// Ironic API
	svcs, err := service.GetServicesListWithLabel(
		ctx,
		helper,
		instance.Namespace,
		GetServiceOpenStackOperatorLabel(ironic.Name+"-api"),
	)
	if err != nil {
		return ctrl.Result{}, err
	}

	// make sure to get to EndpointConfig when all service got created
	if len(svcs.Items) == len(instance.Spec.Ironic.Template.IronicAPI.Override.Service) {
		endpointDetails, ctrlResult, err := EnsureEndpointConfig(
			ctx,
			instance,
			helper,
			ironic,
			svcs,
			instance.Spec.Ironic.Template.IronicAPI.Override.Service,
			instance.Spec.Ironic.APIOverride,
			corev1beta1.OpenStackControlPlaneExposeIronicReadyCondition,
			false, // TODO (mschuppert) could be removed when all integrated service support TLS
			instance.Spec.Ironic.Template.IronicAPI.TLS,
		)
		if err != nil {
			return ctrlResult, err
		} else if (ctrlResult != ctrl.Result{}) {
			return ctrlResult, nil
		}

		instance.Spec.Ironic.Template.IronicAPI.Override.Service = endpointDetails.GetEndpointServiceOverrides()
		// update TLS settings with cert secret
		instance.Spec.Ironic.Template.IronicAPI.TLS.API.Public.SecretName = endpointDetails.GetEndptCertSecret(service.EndpointPublic)
		instance.Spec.Ironic.Template.IronicAPI.TLS.API.Internal.SecretName = endpointDetails.GetEndptCertSecret(service.EndpointInternal)
	}

	// Ironic Inspector
	svcs, err = service.GetServicesListWithLabel(
		ctx,
		helper,
		instance.Namespace,
		GetServiceOpenStackOperatorLabel(ironic.Name+"-inspector"),
	)
	if err != nil {
		return ctrl.Result{}, err
	}

	// make sure to get to EndpointConfig when all service got created
	if len(svcs.Items) == len(instance.Spec.Ironic.Template.IronicInspector.Override.Service) {
		endpointDetails, ctrlResult, err := EnsureEndpointConfig(
			ctx,
			instance,
			helper,
			ironic,
			svcs,
			instance.Spec.Ironic.Template.IronicInspector.Override.Service,
			instance.Spec.Ironic.InspectorOverride,
			corev1beta1.OpenStackControlPlaneExposeIronicReadyCondition,
			false, // TODO (mschuppert) could be removed when all integrated service support TLS
			instance.Spec.Ironic.Template.IronicInspector.TLS,
		)
		if err != nil {
			return ctrlResult, err
		} else if (ctrlResult != ctrl.Result{}) {
			return ctrlResult, nil
		}
		// set service overrides
		instance.Spec.Ironic.Template.IronicInspector.Override.Service = endpointDetails.GetEndpointServiceOverrides()
		// update TLS settings with cert secret
		instance.Spec.Ironic.Template.IronicInspector.TLS.API.Public.SecretName = endpointDetails.GetEndptCertSecret(service.EndpointPublic)
		instance.Spec.Ironic.Template.IronicInspector.TLS.API.Internal.SecretName = endpointDetails.GetEndptCertSecret(service.EndpointInternal)
	}

	Log.Info("Reconciling Ironic", "Ironic.Namespace", instance.Namespace, "Ironic.Name", "ironic")
	op, err := controllerutil.CreateOrPatch(ctx, helper.GetClient(), ironic, func() error {
		instance.Spec.Ironic.Template.DeepCopyInto(&ironic.Spec.IronicSpecCore)

		ironic.Spec.Images.API = *version.Status.ContainerImages.IronicAPIImage
		ironic.Spec.Images.Conductor = *version.Status.ContainerImages.IronicConductorImage
		ironic.Spec.Images.Inspector = *version.Status.ContainerImages.IronicInspectorImage
		ironic.Spec.Images.NeutronAgent = *version.Status.ContainerImages.IronicNeutronAgentImage
		ironic.Spec.Images.Pxe = *version.Status.ContainerImages.IronicPxeImage
		ironic.Spec.Images.IronicPythonAgent = *version.Status.ContainerImages.IronicPythonAgentImage

		if ironic.Spec.Secret == "" {
			ironic.Spec.Secret = instance.Spec.Secret
		}

		err := controllerutil.SetControllerReference(helper.GetBeforeObject(), ironic, helper.GetScheme())
		if err != nil {
			return err
		}
		return nil
	})

	if err != nil {
		instance.Status.Conditions.Set(condition.FalseCondition(
			corev1beta1.OpenStackControlPlaneIronicReadyCondition,
			condition.ErrorReason,
			condition.SeverityWarning,
			corev1beta1.OpenStackControlPlaneIronicReadyErrorMessage,
			err.Error()))
		return ctrl.Result{}, err
	}
	if op != controllerutil.OperationResultNone {
		Log.Info(fmt.Sprintf("ironic %s - %s", ironic.Name, op))
	}

	if ironic.Status.ObservedGeneration == ironic.Generation && ironic.IsReady() {
		Log.Info("Ironic ready condition is true")
		instance.Status.ContainerImages.IronicAPIImage = version.Status.ContainerImages.IronicAPIImage
		instance.Status.ContainerImages.IronicConductorImage = version.Status.ContainerImages.IronicConductorImage
		instance.Status.ContainerImages.IronicInspectorImage = version.Status.ContainerImages.IronicInspectorImage
		instance.Status.ContainerImages.IronicNeutronAgentImage = version.Status.ContainerImages.IronicNeutronAgentImage
		instance.Status.ContainerImages.IronicPxeImage = version.Status.ContainerImages.IronicPxeImage
		instance.Status.ContainerImages.IronicPythonAgentImage = version.Status.ContainerImages.IronicPythonAgentImage
		instance.Status.Conditions.MarkTrue(corev1beta1.OpenStackControlPlaneIronicReadyCondition, corev1beta1.OpenStackControlPlaneIronicReadyMessage)
	} else {
		// We want to mirror the condition of the highest priority from the Ironic resource into the instance
		// under the condition of type OpenStackControlPlaneIronicReadyCondition, but only if the sub-resource
		// currently has any conditions (which won't be true for the initial creation of the sub-resource, since
		// it has not gone through a reconcile loop yet to have any conditions).  If this condition ends up being
		// the highest priority condition in the OpenStackControlPlane, it will appear in the OpenStackControlPlane's
		// "Ready" condition at the end of the reconciliation loop, clearly surfacing the condition to the user in
		// the "oc get oscontrolplane -n <namespace>" output.
		if len(ironic.Status.Conditions) > 0 {
			MirrorSubResourceCondition(ironic.Status.Conditions, corev1beta1.OpenStackControlPlaneIronicReadyCondition, instance, ironic.Kind)
		} else {
			// Default to the associated "running" condition message for the sub-resource if it currently lacks any conditions for mirroring
			instance.Status.Conditions.Set(condition.FalseCondition(
				corev1beta1.OpenStackControlPlaneIronicReadyCondition,
				condition.RequestedReason,
				condition.SeverityInfo,
				corev1beta1.OpenStackControlPlaneIronicReadyRunningMessage))
		}
	}

	return ctrl.Result{}, nil

}

// IronicImageMatch returns true if the ironic images match on the ControlPlane and Version, or if Ironic is not enabled
func IronicImageMatch(ctx context.Context, controlPlane *corev1beta1.OpenStackControlPlane, version *corev1beta1.OpenStackVersion) bool {
	Log := GetLogger(ctx)
	if controlPlane.Spec.Ironic.Enabled {
		if !stringPointersEqual(controlPlane.Status.ContainerImages.IronicAPIImage, version.Status.ContainerImages.IronicAPIImage) ||
			!stringPointersEqual(controlPlane.Status.ContainerImages.IronicConductorImage, version.Status.ContainerImages.IronicConductorImage) ||
			!stringPointersEqual(controlPlane.Status.ContainerImages.IronicInspectorImage, version.Status.ContainerImages.IronicInspectorImage) ||
			!stringPointersEqual(controlPlane.Status.ContainerImages.IronicNeutronAgentImage, version.Status.ContainerImages.IronicNeutronAgentImage) ||
			!stringPointersEqual(controlPlane.Status.ContainerImages.IronicPxeImage, version.Status.ContainerImages.IronicPxeImage) ||
			!stringPointersEqual(controlPlane.Status.ContainerImages.IronicPythonAgentImage, version.Status.ContainerImages.IronicPythonAgentImage) {
			Log.Info("Ironic images do not match")
			return false
		}
	}

	return true
}