watcher.go

package openstack

import (
	"context"
	"fmt"

	"github.com/openstack-k8s-operators/lib-common/modules/common/condition"
	"github.com/openstack-k8s-operators/lib-common/modules/common/helper"
	"github.com/openstack-k8s-operators/lib-common/modules/common/service"

	"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"

	corev1beta1 "github.com/openstack-k8s-operators/openstack-operator/api/core/v1beta1"
	watcherv1 "github.com/openstack-k8s-operators/watcher-operator/api/v1beta1"
	k8s_errors "k8s.io/apimachinery/pkg/api/errors"
	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
	"k8s.io/apimachinery/pkg/types"
	ctrl "sigs.k8s.io/controller-runtime"
)

// ReconcileWatcher -
func ReconcileWatcher(ctx context.Context, instance *corev1beta1.OpenStackControlPlane, version *corev1beta1.OpenStackVersion, helper *helper.Helper) (ctrl.Result, error) {
	watcher := &watcherv1.Watcher{
		ObjectMeta: metav1.ObjectMeta{
			Name:      "watcher",
			Namespace: instance.Namespace,
		},
	}

	if !instance.Spec.Watcher.Enabled {
		if res, err := EnsureDeleted(ctx, helper, watcher); err != nil {
			return res, err
		}
		instance.Status.Conditions.Remove(corev1beta1.OpenStackControlPlaneWatcherReadyCondition)
		instance.Status.Conditions.Remove(corev1beta1.OpenStackControlPlaneExposeWatcherReadyCondition)
		instance.Status.ContainerImages.WatcherAPIImage = nil
		instance.Status.ContainerImages.WatcherApplierImage = nil
		instance.Status.ContainerImages.WatcherDecisionEngineImage = nil
		// Clean up AC CRs when service is disabled
		if err := CleanupApplicationCredentialForService(ctx, helper, instance, watcher.Name); err != nil {
			return ctrl.Result{}, err
		}
		return ctrl.Result{}, nil
	}

	if instance.Spec.Watcher.Template == nil {
		instance.Spec.Watcher.Template = &watcherv1.WatcherSpecCore{}
	}

	// Note: Migration from rabbitMqClusterName to messagingBus.cluster is handled by the webhook
	// via annotation-based triggers. No direct spec mutation here to avoid GitOps conflicts.

	// add selector to service overrides
	for _, endpointType := range []service.Endpoint{service.EndpointPublic, service.EndpointInternal} {
		if instance.Spec.Watcher.Template.APIServiceTemplate.Override.Service == nil {
			instance.Spec.Watcher.Template.APIServiceTemplate.Override.Service = map[service.Endpoint]service.RoutedOverrideSpec{}
		}
		instance.Spec.Watcher.Template.APIServiceTemplate.Override.Service[endpointType] = AddServiceOpenStackOperatorLabel(
			instance.Spec.Watcher.Template.APIServiceTemplate.Override.Service[endpointType],
			watcher.Name)
	}

	// When component services got created check if there is the need to create a route
	if err := helper.GetClient().Get(ctx, types.NamespacedName{Name: "watcher", Namespace: instance.Namespace}, watcher); err != nil {
		if !k8s_errors.IsNotFound(err) {
			return ctrl.Result{}, err
		}
	}

	// Application Credential Management (Day-2 operation)
	// Watcher uses pointer fields, safely extract values
	watcherReady := watcher.Status.Conditions != nil && watcher.Status.ObservedGeneration == watcher.Generation && watcher.IsReady()

	// Helper to get Watcher values (which are pointers) with fallback logic
	getWatcherSecret := func() string {
		if instance.Spec.Watcher.Template.Secret != nil && *instance.Spec.Watcher.Template.Secret != "" {
			return *instance.Spec.Watcher.Template.Secret
		}
		// Apply same fallback as in CreateOrPatch
		return instance.Spec.Secret
	}
	getWatcherServiceUser := func() string {
		if instance.Spec.Watcher.Template.ServiceUser != nil {
			return *instance.Spec.Watcher.Template.ServiceUser
		}
		return ""
	}
	getWatcherPasswordSelector := func() string {
		if instance.Spec.Watcher.Template.PasswordSelectors.Service != nil {
			return *instance.Spec.Watcher.Template.PasswordSelectors.Service
		}
		return ""
	}

	// Always reconcile AC - EnsureApplicationCredentialForService checks cluster state and handles the full AC lifecycle.
	if instance.Spec.Watcher.ApplicationCredential != nil ||
		instance.Spec.Watcher.Template.Auth.ApplicationCredentialSecret != "" {

		acSecretName, acResult, err := EnsureApplicationCredentialForService(
			ctx,
			helper,
			instance,
			watcher.Name,
			watcherReady,
			getWatcherSecret(),
			getWatcherPasswordSelector(),
			getWatcherServiceUser(),
			instance.Spec.Watcher.ApplicationCredential,
		)
		if err != nil {
			return ctrl.Result{}, err
		}

		// If AC is not ready, return immediately without updating the service CR
		if (acResult != ctrl.Result{}) {
			return acResult, nil
		}

		// Set ApplicationCredentialSecret based on what the helper returned:
		// - If AC disabled: returns ""
		// - If AC enabled and ready: returns the AC secret name
		instance.Spec.Watcher.Template.Auth.ApplicationCredentialSecret = acSecretName
	}

	// preserve any previously set TLS certs, set CA cert
	if instance.Spec.TLS.PodLevel.Enabled {
		instance.Spec.Watcher.Template.APIServiceTemplate.TLS = watcher.Spec.APIServiceTemplate.TLS
	}
	instance.Spec.Watcher.Template.APIServiceTemplate.TLS.CaBundleSecretName = instance.Status.TLS.CaBundleSecretName

	svcs, err := service.GetServicesListWithLabel(
		ctx,
		helper,
		instance.Namespace,
		GetServiceOpenStackOperatorLabel(watcher.Name),
	)
	if err != nil {
		return ctrl.Result{}, err
	}

	// make sure to get to EndpointConfig when all service got created
	if len(svcs.Items) == len(instance.Spec.Watcher.Template.APIServiceTemplate.Override.Service) {
		endpointDetails, ctrlResult, err := EnsureEndpointConfig(
			ctx,
			instance,
			helper,
			watcher,
			svcs,
			instance.Spec.Watcher.Template.APIServiceTemplate.Override.Service,
			instance.Spec.Watcher.APIOverride,
			corev1beta1.OpenStackControlPlaneExposeWatcherReadyCondition,
			false, // TODO: (mschuppert) could be removed when all integrated service support TLS
			instance.Spec.Watcher.Template.APIServiceTemplate.TLS,
		)
		if err != nil {
			return ctrlResult, err
		} else if (ctrlResult != ctrl.Result{}) {
			return ctrlResult, nil
		}
		// set service overrides
		instance.Spec.Watcher.Template.APIServiceTemplate.Override.Service = endpointDetails.GetEndpointServiceOverrides()
		// update TLS settings with cert secret
		instance.Spec.Watcher.Template.APIServiceTemplate.TLS.API.Public.SecretName = endpointDetails.GetEndptCertSecret(service.EndpointPublic)
		instance.Spec.Watcher.Template.APIServiceTemplate.TLS.API.Internal.SecretName = endpointDetails.GetEndptCertSecret(service.EndpointInternal)
	}

	if instance.Spec.Watcher.Template.NodeSelector == nil && len(instance.Spec.NodeSelector) > 0 {
		instance.Spec.Watcher.Template.NodeSelector = &instance.Spec.NodeSelector
	}

	// When there's no Topology referenced in the Service Template, inject the
	// top-level one
	// NOTE: This does not check the Service subCRs: by default the generated
	// subCRs inherit the top-level TopologyRef unless an override is present
	if instance.Spec.Watcher.Template.TopologyRef == nil {
		instance.Spec.Watcher.Template.TopologyRef = instance.Spec.TopologyRef
	}

	// Propagate MessagingBus from top-level to template if not set
	// Template-level takes precedence over top-level
	if instance.Spec.MessagingBus != nil && instance.Spec.MessagingBus.Cluster != "" {
		if instance.Spec.Watcher.Template.MessagingBus.Cluster == "" {
			instance.Spec.Watcher.Template.MessagingBus = *instance.Spec.MessagingBus
		}
	}

	// Propagate NotificationsBus from top-level to template if not set
	// Template-level takes precedence over top-level
	if instance.Spec.NotificationsBus != nil {
		if instance.Spec.Watcher.Template.NotificationsBus == nil {
			instance.Spec.Watcher.Template.NotificationsBus = instance.Spec.NotificationsBus
		}
	}

	helper.GetLogger().Info("Reconciling Watcher", "Watcher.Namespace", instance.Namespace, "Watcher.Name", "watcher")
	op, err := controllerutil.CreateOrPatch(ctx, helper.GetClient(), watcher, func() error {
		instance.Spec.Watcher.Template.DeepCopyInto(&watcher.Spec.WatcherSpecCore)
		// Explicitly propagate NotificationsBus only if non-nil to allow webhook defaulting from rabbitMqClusterName
		if instance.Spec.Watcher.Template.NotificationsBus != nil {
			watcher.Spec.NotificationsBus = instance.Spec.Watcher.Template.NotificationsBus
		}

		if version.Status.ContainerImages.WatcherAPIImage == nil ||
			version.Status.ContainerImages.WatcherApplierImage == nil ||
			version.Status.ContainerImages.WatcherDecisionEngineImage == nil {
			return fmt.Errorf("no Watcher images found in the OpenStackVersion")
		}
		watcher.Spec.APIContainerImageURL = *version.Status.ContainerImages.WatcherAPIImage
		watcher.Spec.ApplierContainerImageURL = *version.Status.ContainerImages.WatcherApplierImage
		watcher.Spec.DecisionEngineContainerImageURL = *version.Status.ContainerImages.WatcherDecisionEngineImage

		if *watcher.Spec.Secret == "" {
			*watcher.Spec.Secret = instance.Spec.Secret
		}

		err := controllerutil.SetControllerReference(helper.GetBeforeObject(), watcher, helper.GetScheme())
		if err != nil {
			return err
		}
		return nil
	})
	if err != nil {
		instance.Status.Conditions.Set(condition.FalseCondition(
			corev1beta1.OpenStackControlPlaneWatcherReadyCondition,
			condition.ErrorReason,
			condition.SeverityWarning,
			corev1beta1.OpenStackControlPlaneWatcherReadyErrorMessage,
			err.Error()))
		return ctrl.Result{}, err
	}
	if op != controllerutil.OperationResultNone {
		helper.GetLogger().Info(fmt.Sprintf("watcher %s - %s", watcher.Name, op))
	}

	if watcher.Status.ObservedGeneration == watcher.Generation && watcher.IsReady() {
		helper.GetLogger().Info("Watcher ready condition is true")
		instance.Status.ContainerImages.WatcherAPIImage = version.Status.ContainerImages.WatcherAPIImage
		instance.Status.ContainerImages.WatcherApplierImage = version.Status.ContainerImages.WatcherApplierImage
		instance.Status.ContainerImages.WatcherDecisionEngineImage = version.Status.ContainerImages.WatcherDecisionEngineImage
		instance.Status.Conditions.MarkTrue(corev1beta1.OpenStackControlPlaneWatcherReadyCondition, corev1beta1.OpenStackControlPlaneWatcherReadyMessage)
	} else {
		// We want to mirror the condition of the highest priority from the Watcher resource into the instance
		// under the condition of type OpenStackControlPlaneWatcherReadyCondition, but only if the sub-resource
		// currently has any conditions (which won't be true for the initial creation of the sub-resource, since
		// it has not gone through a reconcile loop yet to have any conditions).  If this condition ends up being
		// the highest priority condition in the OpenStackControlPlane, it will appear in the OpenStackControlPlane's
		// "Ready" condition at the end of the reconciliation loop, clearly surfacing the condition to the user in
		// the "oc get oscontrolplane -n <namespace>" output.
		if len(watcher.Status.Conditions) > 0 {
			MirrorSubResourceCondition(watcher.Status.Conditions, corev1beta1.OpenStackControlPlaneWatcherReadyCondition, instance, watcher.Kind)
		} else {
			// Default to the associated "running" condition message for the sub-resource if it currently lacks any conditions for mirroring
			instance.Status.Conditions.Set(condition.FalseCondition(
				corev1beta1.OpenStackControlPlaneWatcherReadyCondition,
				condition.RequestedReason,
				condition.SeverityInfo,
				corev1beta1.OpenStackControlPlaneWatcherReadyRunningMessage))
		}
	}

	return ctrl.Result{}, nil
}

// WatcherImageMatch - return true if the Watcher images match on the ControlPlane and Version, or if Watcher is not enabled
func WatcherImageMatch(ctx context.Context, controlPlane *corev1beta1.OpenStackControlPlane, version *corev1beta1.OpenStackVersion) bool {
	Log := GetLogger(ctx)

	if controlPlane.Spec.Watcher.Enabled {
		if !stringPointersEqual(controlPlane.Status.ContainerImages.WatcherAPIImage, version.Status.ContainerImages.WatcherAPIImage) ||
			!stringPointersEqual(controlPlane.Status.ContainerImages.WatcherApplierImage, version.Status.ContainerImages.WatcherApplierImage) ||
			!stringPointersEqual(controlPlane.Status.ContainerImages.WatcherDecisionEngineImage, version.Status.ContainerImages.WatcherDecisionEngineImage) {
			Log.Info("Watcher images do not match")
			return false
		}
	}

	return true
}