Skip to content

Commit 01e2318

Browse files
Merge pull request #897 from fao89/oc
Use oc kustomize instead of kustomize to build the docs
2 parents c43c0f2 + a95786d commit 01e2318

2 files changed

Lines changed: 12 additions & 6 deletions

File tree

Makefile

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -107,9 +107,8 @@ docs-clean:
107107
rm -r docs_build
108108

109109
.PHONY: docs-examples
110-
docs-kustomize-examples: export KUSTOMIZE_VERSION=v5.0.1
111-
docs-kustomize-examples: yq kustomize ## Generate updated docs from examples using kustomize
112-
KUSTOMIZE=$(KUSTOMIZE) LOCALBIN=$(LOCALBIN) ./docs/kustomize_to_docs.sh
110+
docs-kustomize-examples: oc yq ## Generate updated docs from examples using kustomize
111+
LOCALBIN=$(LOCALBIN) ./docs/kustomize_to_docs.sh
113112

114113
##@ General
115114

@@ -276,6 +275,7 @@ CONTROLLER_TOOLS_VERSION ?= v0.11.1
276275
CRD_MARKDOWN_VERSION ?= v0.0.3
277276
KUTTL_VERSION ?= 0.17.0
278277
GOTOOLCHAIN_VERSION ?= go1.21.0
278+
OC_VERSION ?= 4.14.0
279279

280280
KUSTOMIZE_INSTALL_SCRIPT ?= "https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh"
281281
.PHONY: kustomize
@@ -369,11 +369,17 @@ endif
369369
endif
370370

371371
.PHONY: yq
372-
yq: ## Download and install yq in local env
372+
yq: $(LOCALBIN) ## Download and install yq in local env
373373
test -s $(LOCALBIN)/yq || ( cd $(LOCALBIN) &&\
374374
wget https://github.com/mikefarah/yq/releases/latest/download/yq_linux_amd64.tar.gz -O - |\
375375
tar xz && mv yq_linux_amd64 $(LOCALBIN)/yq )
376376

377+
.PHONY: oc
378+
oc: $(LOCALBIN) ## Download and install oc in local env
379+
test -s $(LOCALBIN)/oc || ( cd $(LOCALBIN) &&\
380+
wget https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/$(OC_VERSION)/openshift-client-linux-$(OC_VERSION).tar.gz -O - |\
381+
tar xz)
382+
377383
# Build make variables to export for shell
378384
MAKE_ENV := $(shell echo '$(.VARIABLES)' | awk -v RS=' ' '/^(IMAGE)|.*?(REGISTRY)$$/')
379385
SHELL_EXPORT = $(foreach v,$(MAKE_ENV),$(v)='$($(v))')

docs/kustomize_to_docs.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ BAREMETAL=docs/assemblies/ref_example-OpenStackDataPlaneNodeSet-CR-for-bare-meta
55
FOOTER=$(sed '0,/----/d' $BAREMETAL | sed -e '0,/----/d')
66
sed -i '/----/q' $BAREMETAL
77
sed -i 's/preprovisioned/baremetal/' config/samples/dataplane/no_vars_from/kustomization.yaml
8-
$KUSTOMIZE --load-restrictor LoadRestrictionsNone build config/samples/dataplane/no_vars_from | $LOCALBIN/yq ' select(.kind == "OpenStackDataPlaneNodeSet")' >> $BAREMETAL
8+
$LOCALBIN/oc kustomize --load-restrictor LoadRestrictionsNone config/samples/dataplane/no_vars_from | $LOCALBIN/yq ' select(.kind == "OpenStackDataPlaneNodeSet")' >> $BAREMETAL
99
sed -i 's/\/baremetal/\/preprovisioned/' config/samples/dataplane/no_vars_from/kustomization.yaml
1010
echo -e "----\n$FOOTER" >> $BAREMETAL
1111

@@ -32,7 +32,7 @@ done
3232
PREPROVISIONED=docs/assemblies/ref_example-OpenStackDataPlaneNodeSet-CR-for-preprovisioned-nodes.adoc
3333
FOOTER=$(sed '0,/----/d' $PREPROVISIONED | sed -e '0,/----/d')
3434
sed -i '/----/q' $PREPROVISIONED
35-
$KUSTOMIZE --load-restrictor LoadRestrictionsNone build config/samples/dataplane/no_vars_from | $LOCALBIN/yq ' select(.kind == "OpenStackDataPlaneNodeSet")' >> $PREPROVISIONED
35+
$LOCALBIN/oc kustomize --load-restrictor LoadRestrictionsNone config/samples/dataplane/no_vars_from | $LOCALBIN/yq ' select(.kind == "OpenStackDataPlaneNodeSet")' >> $PREPROVISIONED
3636
echo -e "----\n$FOOTER" >> $PREPROVISIONED
3737

3838
COUNT=1

0 commit comments

Comments
 (0)