Add functional and kuttl tests

Signed-off-by: Veronika Fisarova <vfisarov@redhat.com>

Author: Deydra71

apis/bases/core.openstack.org_openstackcontrolplanes.yaml

@@ -55,7 +55,6 @@ spec:
                     type: integer
                   roles:
                     default:
-                    - admin
                     - service
                     items:
                       type: string

apis/core/v1beta1/openstackcontrolplane_types.go

@@ -880,7 +880,7 @@ type ApplicationCredentialSection struct {
 	GracePeriodDays *int `json:"gracePeriodDays,omitempty"`
 
 	// +kubebuilder:validation:Optional
-	// +kubebuilder:default={"admin","service"}
+	// +kubebuilder:default={"service"}
 	// +kubebuilder:validation:MinItems=1
 	// Roles to assign to the ApplicationCredential
 	Roles []string `json:"roles,omitempty"`

config/crd/bases/core.openstack.org_openstackcontrolplanes.yaml

@@ -55,7 +55,6 @@ spec:
                     type: integer
                   roles:
                     default:
-                    - admin
                     - service
                     items:
                       type: string

config/samples/applicationcredentials/kustomization.yaml

@@ -0,0 +1,14 @@
+resources:
+- ../../base/openstackcontrolplane
+
+patches:
+- target:
+    kind: OpenStackControlPlane
+    name: .*
+  patch: |-
+    - op: replace
+      path: /metadata/name
+      value: openstack
+- target:
+    kind: OpenStackControlPlane
+  path: patch.yaml

config/samples/applicationcredentials/patch.yaml

@@ -0,0 +1,24 @@
+apiVersion: core.openstack.org/v1beta1
+kind: OpenStackControlPlane
+metadata:
+  name: openstack
+spec:
+  applicationCredential:
+    enabled: true
+    expirationDays: 200
+    gracePeriodDays: 90
+    roles:
+      - service
+    unrestricted: false
+  barbican:
+    applicationCredential:
+      enabled: true
+  cinder:
+    applicationCredential:
+      enabled: true
+      expirationDays: 10
+      gracePeriodDays: 5
+      roles:
+        - admin
+        - service
+      unrestricted: true

pkg/openstack/applicationcredential.go

@@ -155,10 +155,9 @@ func ReconcileApplicationCredentials(
 
 			rel := &url.URL{Path: path.Join(u.Path, "auth", "tokens")}
 			full := u.ResolveReference(rel)
-			// full.Path guarantees to start with /
 			acObj.Spec.AccessRules = []keystonev1.ACRule{{
 				Service: "identity",
-				Path:    full.Path, // e.g. "/v3/auth/tokens" or "/auth/tokens"
+				Path:    full.Path, // /v3/auth/tokens or /auth/tokens
 				Method:  "POST",
 			}}
 

tests/functional/ctlplane/openstackoperator_controller_test.go

@@ -3087,5 +3087,43 @@ var _ = Describe("OpenStackOperator controller galera and rabbitmq", func() {
 		})
 
 	})
+})
+
+var _ = Describe("Application Credentials are enabled in control plane", func() {
+	When("global application credentials are enabled", func() {
+		BeforeEach(func() {
+			spec := GetDefaultOpenStackControlPlaneSpec()
+			spec["applicationCredential"] = map[string]interface{}{"enabled": true}
+			spec["cinder"] = map[string]interface{}{
+				"enabled": true,
+				"applicationCredential": map[string]interface{}{
+					"enabled":         true,
+					"expirationDays":  100,
+					"gracePeriodDays": 50,
+					"roles":           []string{"custom", "role"},
+					"unrestricted":    true,
+				},
+			}
 
+			DeferCleanup(th.DeleteInstance,
+				CreateOpenStackControlPlane(names.OpenStackControlplaneName, spec),
+			)
+		})
+
+		It("should fill defaults", func() {
+			cp := GetOpenStackControlPlane(names.OpenStackControlplaneName)
+			Expect(cp.Spec.ApplicationCredential.Enabled).To(BeTrue())
+			Expect(*cp.Spec.ApplicationCredential.ExpirationDays).To(Equal(365))
+			Expect(*cp.Spec.ApplicationCredential.GracePeriodDays).To(Equal(182))
+			Expect(cp.Spec.ApplicationCredential.Roles).To(ConsistOf("service"))
+			Expect(*cp.Spec.ApplicationCredential.Unrestricted).To(BeFalse())
+
+			ac := cp.Spec.Cinder.ApplicationCredential
+			Expect(*ac.ExpirationDays).To(Equal(100))
+			Expect(*ac.GracePeriodDays).To(Equal(50))
+			Expect(ac.Roles).To(ConsistOf("custom", "role"))
+			Expect(*ac.Unrestricted).To(BeTrue())
+
+		})
+	})
 })

tests/kuttl/common/appcred-config.yaml

@@ -0,0 +1,24 @@
+apiVersion: core.openstack.org/v1beta1
+kind: OpenStackControlPlane
+metadata:
+  name: openstackcontrolplane
+spec:
+  applicationCredential:
+    enabled: true
+    expirationDays: 200
+    gracePeriodDays: 90
+    roles:
+      - service
+    unrestricted: false
+  barbican:
+    applicationCredential:
+      enabled: true
+  cinder:
+    applicationCredential:
+      enabled: true
+      expirationDays: 10
+      gracePeriodDays: 5
+      roles:
+        - admin
+        - service
+      unrestricted: true

tests/kuttl/tests/ctlplane-basic-with-appcred/01-assert-deploy-openstack.yaml

@@ -0,0 +1 @@
+../../common/assert-sample-deployment.yaml

tests/kuttl/tests/ctlplane-basic-with-appcred/01-deploy-openstack.yaml

@@ -0,0 +1,5 @@
+apiVersion: kuttl.dev/v1beta1
+kind: TestStep
+commands:
+  - script: |
+      oc kustomize ../../../../config/samples/base/openstackcontrolplane | oc apply -n $NAMESPACE -f -