Skip to content

Commit 38173d7

Browse files
committed
Fix functional tests
* manila introduced validation webhooks check in [1] for required fields. This adds thise fields in the manila template. * fixes heat password selector from AuthEncryptionKey -> authEncryptionKey * openstackclient does not (yet) have an Enabled parameter [1] openstack-k8s-operators/manila-operator#418 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
1 parent ae032e1 commit 38173d7

2 files changed

Lines changed: 20 additions & 21 deletions

File tree

tests/functional/ctlplane/base_test.go

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -504,7 +504,7 @@ func GetDefaultOpenStackControlPlaneSpec() map[string]interface{} {
504504
"databaseInstance": "openstack",
505505
"secret": "osp-secret",
506506
"passwordSelectors": map[string]interface{}{
507-
"AuthEncryptionKey": "HeatAuthEncryptionKey",
507+
"authEncryptionKey": "HeatAuthEncryptionKey",
508508
},
509509
}
510510
telemetryTemplate := map[string]interface{}{
@@ -521,6 +521,22 @@ func GetDefaultOpenStackControlPlaneSpec() map[string]interface{} {
521521
"enabled": false,
522522
},
523523
}
524+
manilaTemplate := map[string]interface{}{
525+
"rabbitMqClusterName": "rabbitmq",
526+
"memcachedInstance": "memcached",
527+
"databaseAccount": "account",
528+
"manilaAPI": map[string]interface{}{
529+
"replicas": 1,
530+
},
531+
"manilaScheduler": map[string]interface{}{
532+
"replicas": 1,
533+
},
534+
"manilaShares": map[string]interface{}{
535+
"share1": map[string]interface{}{
536+
"replicas": 1,
537+
},
538+
},
539+
}
524540

525541
return map[string]interface{}{
526542
"secret": "osp-secret",
@@ -578,11 +594,10 @@ func GetDefaultOpenStackControlPlaneSpec() map[string]interface{} {
578594
"barbican": map[string]interface{}{
579595
"enabled": false,
580596
},
581-
"openstackclient": map[string]interface{}{
582-
"enabled": true,
583-
},
597+
"openstackclient": map[string]interface{}{},
584598
"manila": map[string]interface{}{
585-
"enabled": true,
599+
"enabled": true,
600+
"template": manilaTemplate,
586601
},
587602
"heat": map[string]interface{}{
588603
"enabled": true,

tests/functional/ctlplane/openstackoperator_controller_test.go

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1459,22 +1459,6 @@ var _ = Describe("OpenStackOperator controller", func() {
14591459
BeforeEach(func() {
14601460
spec := GetDefaultOpenStackControlPlaneSpec()
14611461
spec["tls"] = GetTLSPublicSpec()
1462-
spec["manila"] = map[string]interface{}{
1463-
"enabled": true,
1464-
"template": map[string]interface{}{
1465-
"manilaAPI": map[string]interface{}{
1466-
"replicas": 1,
1467-
},
1468-
"manilaScheduler": map[string]interface{}{
1469-
"replicas": 1,
1470-
},
1471-
"manilaShares": map[string]interface{}{
1472-
"share1": map[string]interface{}{
1473-
"replicas": 1,
1474-
},
1475-
},
1476-
},
1477-
}
14781462
DeferCleanup(
14791463
th.DeleteInstance,
14801464
CreateOpenStackControlPlane(names.OpenStackControlplaneName, spec),

0 commit comments

Comments
 (0)