Set ManilaShareV1 annotation via OpenStackVersion

This patch adds support for ManilaShareV1 configuration in OpenStack
operator. It ensures that the annotation "manila.openstack.org/sharev1"
is set to "true" by default, so we can easily invert the logic for RHOSO
19, where share service and v1 endpoints are removed.

Signed-off-by: Francesco Pantano <fpantano@redhat.com>

Author: fmount

api/bases/core.openstack.org_openstackversions.yaml

@@ -250,6 +250,8 @@ spec:
                   properties:
                     glanceWsgi:
                       type: string
+                    manilaSharev1:
+                      type: string
                     rabbitmqVersion:
                       type: string
                   type: object
@@ -687,6 +689,8 @@ spec:
                 properties:
                   glanceWsgi:
                     type: string
+                  manilaSharev1:
+                    type: string
                   rabbitmqVersion:
                     type: string
                 type: object

api/core/v1beta1/openstackversion_types.go

@@ -179,6 +179,7 @@ type ContainerTemplate struct {
 type ServiceDefaults struct {
 	GlanceWsgi      *string `json:"glanceWsgi,omitempty"`
 	RabbitmqVersion *string `json:"rabbitmqVersion,omitempty"`
+	ManilaSharev1   *string `json:"manilaSharev1,omitempty"`
 }
 
 // OpenStackVersionStatus defines the observed state of OpenStackVersion

api/core/v1beta1/zz_generated.deepcopy.go

@@ -21476,6 +21476,8 @@ spec:
                   properties:
                     glanceWsgi:
                       type: string
+                    manilaSharev1:
+                      type: string
                     rabbitmqVersion:
                       type: string
                   type: object
@@ -21913,6 +21915,8 @@ spec:
                 properties:
                   glanceWsgi:
                     type: string
+                  manilaSharev1:
+                    type: string
                   rabbitmqVersion:
                     type: string
                 type: object

bindata/crds/crds.yaml

@@ -250,6 +250,8 @@ spec:
                   properties:
                     glanceWsgi:
                       type: string
+                    manilaSharev1:
+                      type: string
                     rabbitmqVersion:
                       type: string
                   type: object
@@ -687,6 +689,8 @@ spec:
                 properties:
                   glanceWsgi:
                     type: string
+                  manilaSharev1:
+                    type: string
                   rabbitmqVersion:
                     type: string
                 type: object

config/crd/bases/core.openstack.org_openstackversions.yaml

@@ -216,6 +216,14 @@ func ReconcileManila(ctx context.Context, instance *corev1beta1.OpenStackControl
 			//manila.Spec.DatabaseInstance = instance.Name // name of MariaDB we create here
 			manila.Spec.DatabaseInstance = "openstack" //FIXME: see above
 		}
+		if manila.GetAnnotations() == nil {
+			manila.SetAnnotations(make(map[string]string))
+		}
+		if version.Status.ServiceDefaults.ManilaSharev1 != nil && *version.Status.ServiceDefaults.ManilaSharev1 == "true" {
+			manila.GetAnnotations()[manilav1.ManilaShareV1Label] = "true"
+		} else {
+			manila.GetAnnotations()[manilav1.ManilaShareV1Label] = "false"
+		}
 		// Append globally defined extraMounts to the service's own list.
 		for _, ev := range instance.Spec.ExtraMounts {
 			manila.Spec.ExtraMounts = append(manila.Spec.ExtraMounts, manilav1.ManilaExtraVolMounts{

internal/openstack/manila.go

@@ -229,6 +229,9 @@ func InitializeOpenStackVersionServiceDefaults(ctx context.Context) *corev1beta1
 	// to new deployment topologies
 	trueString := "true"
 	defaults.GlanceWsgi = &trueString // all new glance deployments use WSGI by default (FR3 and later)
+	// NOTE: In 18 Manila creates sharev1 service and endpoints. From 19 do not create sharev1 anymore
+	// https://review.opendev.org/q/topic:%22remove-v1%22+and+project:openstack/manila
+	defaults.ManilaSharev1 = &trueString // all Manila deployments create sharev1 endpoints by default
 
 	versionString := "4.2"
 	defaults.RabbitmqVersion = &versionString // all new rabbitmq deployments will have rabbitmq-server 4.2 (FR5)