[golang] bump to golang 1.22#1411
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| GOTOOLCHAIN_VERSION ?= go1.21.0 | ||
| OC_VERSION ?= 4.14.0 | ||
| GOTOOLCHAIN_VERSION ?= go1.22.0 | ||
| OC_VERSION ?= 4.16.0 |
There was a problem hiding this comment.
4.18 not yet available
wget https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/4.18.0/openshift-client-linux-4.18.0.tar.gz -O - |\
tar xz)
--2025-04-23 08:46:54-- https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/4.18.0/openshift-client-linux-4.18.0.tar.gz
Resolving mirror.openshift.com (mirror.openshift.com)... 3.167.56.39, 3.167.56.96, 3.167.56.87, ...
Connecting to mirror.openshift.com (mirror.openshift.com)|3.167.56.39|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2025-04-23 08:46:54 ERROR 404: Not Found.
There was a problem hiding this comment.
Can't we just leave OC_VERSION at 4.16 here? We do still support running on that version...
There was a problem hiding this comment.
it was 4.14, I bumped it to 4.16. but I think I'll move this to a separate PR. its not really related to the golang bump.
|
wrong base image/golang version is used in ci |
* bump in go.mod (base and api)
* bump go-toolset in Dockerfile
* bump in github jobs ('.github/workflows')
* Bump the golangci-lint version in the .pre-commit-config.yaml to v1.63.4
* Bump build_root_image in .ci-operator.yaml to ci-build-root-golang-1.22-sdk-1.31
Jira: OSPRH-12935
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
|
This change depends on a change that failed to merge. Change openstack-k8s-operators/install_yamls#1051 is needed. |
|
/retest |
|
recheck |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 similar comments
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@stuggi: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
closing in preference of #1567 |
3 participants
To test on existing env:
go.work*filesgo work initDepends-On: openstack-k8s-operators/install_yamls#1051
Jira: OSPRH-12935