Skip to content

Add ServiceDefaults mechanism for updates support#1439

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
dprince:serviceDefaults
May 21, 2025
Merged

Add ServiceDefaults mechanism for updates support#1439
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
dprince:serviceDefaults

Conversation

@dprince

@dprince dprince commented May 12, 2025

Copy link
Copy Markdown
Contributor

ServiceDefaults is a new feild in the OpenStackVersion status that can be used to manage service defaults during an update.

Older OpenStackVersions won't have newly initialized defaults set and thus we treat them as legacy. In the case of glance they would continue to deploy with httpd+proxypass until the new OpenStackVersion for FR3 is selected and deployed.

Jira: https://issues.redhat.com/browse/OSPRH-16261

@fmount fmount left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dprince for starting this.
I'll try this patch in my local environment and provide an additional feedback, but the direction looks good to me!

Comment thread pkg/openstack/glance.go Outdated
Comment thread pkg/openstack/glance.go Outdated
Comment thread pkg/openstack/glance.go
Comment thread controllers/core/openstackversion_controller.go Outdated
Comment thread apis/core/v1beta1/openstackversion_types.go
@dprince dprince force-pushed the serviceDefaults branch 2 times, most recently from b3a7063 to bdc60aa Compare May 14, 2025 16:17
@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ff78d049c3084e32bad107594374af5a

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 54m 16s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 09m 59s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 32m 59s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT Host unreachable in 2h 40m 06s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 33m 36s
openstack-operator-kuttl FAILURE in 28m 06s (non-voting)

@dprince

dprince commented May 15, 2025

Copy link
Copy Markdown
Contributor Author

recheck

@abays abays left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/cfa58f30c4234764a4b1446a6cf4cb28

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 07m 46s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 37s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 53m 18s
adoption-standalone-to-crc-ceph-provider FAILURE in 1h 40m 14s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 32m 07s
openstack-operator-kuttl FAILURE in 30m 04s (non-voting)

ServiceDefaults is a new feild in the OpenStackVersion status
that can be used to manage service defaults during an update.

Older OpenStackVersions won't have newly initialized defaults set
and thus we treat them as legacy. In the case of glance
they would continue to deploy with httpd+proxypass until
the new OpenStackVersion for FR3 is selected and deployed.

Jira: https://issues.redhat.com/browse/OSPRH-16261
@dprince dprince force-pushed the serviceDefaults branch from bdc60aa to 4e3c854 Compare May 15, 2025 13:51
@openshift-ci openshift-ci Bot removed the lgtm label May 15, 2025
@openshift-ci

openshift-ci Bot commented May 15, 2025

Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@abays abays added the lgtm label May 15, 2025
@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/cca0cf9d4ebd4287bfcbc9aa707f55c5

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 02m 01s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 12m 39s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 43m 39s
adoption-standalone-to-crc-ceph-provider FAILURE in 1h 40m 51s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 40m 44s
openstack-operator-kuttl FAILURE in 27m 18s (non-voting)

@fmount fmount left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented May 15, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, dprince, fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fmount

fmount commented May 15, 2025

Copy link
Copy Markdown
Contributor

recheck

@fmount

fmount commented May 15, 2025

Copy link
Copy Markdown
Contributor

I was able to deploy and test this locally. I can see glance being transitioned from proxypass to wsgi mode. Thank you!

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f41a0902762e4c6db8a91527cf475c94

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 55m 37s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 12m 28s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 39m 27s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT Host unreachable in 2h 38m 54s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 23m 59s
openstack-operator-kuttl FAILURE in 27m 04s (non-voting)

@dprince

dprince commented May 15, 2025

Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f00f2e97a4504f119a6781645d6ab566

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 14m 59s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 09m 17s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 33m 42s
adoption-standalone-to-crc-ceph-provider FAILURE in 2h 59m 20s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 30m 49s
openstack-operator-kuttl FAILURE in 27m 40s (non-voting)

@dprince

dprince commented May 15, 2025

Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5e9c5ce44bab4c73ad12352e598119d7

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 57m 51s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 00s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 43m 39s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 17m 17s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 30m 37s
openstack-operator-kuttl FAILURE in 28m 06s (non-voting)

@stuggi

stuggi commented May 16, 2025

Copy link
Copy Markdown
Contributor

recheck

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5369cd71f1e945acb1ed770ee44e4453

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 51m 43s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 08s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 31m 49s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 13m 39s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 35m 30s
openstack-operator-kuttl FAILURE in 25m 11s (non-voting)

@fmount

fmount commented May 16, 2025

Copy link
Copy Markdown
Contributor

There's currently a CIX for the adoption job that wont' be green until the repositories related issue is solved.

@fmount

fmount commented May 16, 2025

Copy link
Copy Markdown
Contributor

recheck

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e56b11ab42224490a4feaf71ab83010e

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 45m 49s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 14m 34s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 29m 17s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 11m 37s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 31m 00s
openstack-operator-kuttl FAILURE in 26m 24s (non-voting)

@fmount

fmount commented May 18, 2025

Copy link
Copy Markdown
Contributor

recheck

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/348902af93b843228327322caeddd6ae

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 49m 49s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 40s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 30m 35s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT Host unreachable in 2h 35m 28s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 32m 26s
openstack-operator-kuttl RETRY_LIMIT in 7m 17s (non-voting)

@dprince

dprince commented May 19, 2025

Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bda818a7b08f49e3a078e7d1e7557090

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 48m 26s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 10m 09s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 36m 54s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT Host unreachable in 2h 34m 23s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 28m 24s
openstack-operator-kuttl FAILURE in 26m 06s (non-voting)

@rabi

rabi commented May 20, 2025

Copy link
Copy Markdown
Contributor

recheck

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/03b2d4995824407b842d34d09d81b54b

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 56m 43s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 40s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 26m 36s
adoption-standalone-to-crc-ceph-provider FAILURE in 1h 31m 33s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 37m 41s
openstack-operator-kuttl FAILURE in 27m 47s (non-voting)

@dprince

dprince commented May 20, 2025

Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/09d380c40a424417b1839bb4b3536ad1

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 55m 52s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 16s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 39m 55s
adoption-standalone-to-crc-ceph-provider FAILURE in 1h 33m 46s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 30m 36s
openstack-operator-kuttl FAILURE in 27m 31s (non-voting)

@dprince

dprince commented May 20, 2025

Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/98ef380d814d4d25b08620a7dbc3cbb4

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 33m 21s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 15s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 29m 15s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 16m 12s
openstack-operator-tempest-multinode FAILURE in 1h 43m 50s
openstack-operator-kuttl FAILURE in 30m 14s (non-voting)

@dprince

dprince commented May 21, 2025

Copy link
Copy Markdown
Contributor Author

recheck

@openshift-merge-bot openshift-merge-bot Bot merged commit f2575be into openstack-k8s-operators:main May 21, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants