Skip to content

Support IDMS for disconnected automation#1440

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
bshephar:imagedigestmirrorset
Jun 28, 2025
Merged

Support IDMS for disconnected automation#1440
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
bshephar:imagedigestmirrorset

Conversation

@bshephar

Copy link
Copy Markdown
Contributor

This change adds support for IDMS in addition to ICSP when determining whether the OCP cluster is in a disconnected state.

@openshift-ci

openshift-ci Bot commented May 13, 2025

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@bshephar bshephar force-pushed the imagedigestmirrorset branch from ad23987 to feb8448 Compare May 13, 2025 21:53
@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8e851baa3c0d432fb38c1b0f5665fb96

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 57m 54s
podified-multinode-edpm-deployment-crc FAILURE in 1h 36m 38s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 37m 40s
adoption-standalone-to-crc-ceph-provider FAILURE in 2h 38m 24s
openstack-operator-tempest-multinode FAILURE in 1h 38m 31s
✔️ openstack-operator-docs-preview SUCCESS in 2m 12s
openstack-operator-kuttl FAILURE in 25m 25s (non-voting)

@bshephar bshephar force-pushed the imagedigestmirrorset branch from feb8448 to 8faed9e Compare May 14, 2025 10:38
@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5a90d57294e445548cdccf2bdc30eb3c

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 53m 51s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 25s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 32m 45s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT Host unreachable in 2h 39m 25s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 36m 46s
✔️ openstack-operator-docs-preview SUCCESS in 2m 16s
openstack-operator-kuttl FAILURE in 27m 08s (non-voting)

@bshephar

Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e6349212122d4d799cfc5c94c454c22c

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 56m 01s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 12m 38s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 32m 04s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT Host unreachable in 2h 39m 05s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 56m 42s
✔️ openstack-operator-docs-preview SUCCESS in 2m 08s
openstack-operator-kuttl FAILURE in 27m 08s (non-voting)

@bshephar

Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b1596161bd6241f4beb9af62741bf317

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 50m 48s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 12m 13s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 31m 15s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT Host unreachable in 2h 34m 36s
openstack-operator-tempest-multinode RETRY_LIMIT in 13m 01s
✔️ openstack-operator-docs-preview SUCCESS in 2m 14s
openstack-operator-kuttl FAILURE in 27m 54s (non-voting)

@bshephar bshephar marked this pull request as ready for review May 17, 2025 10:41
@openshift-ci openshift-ci Bot requested review from dprince and frenzyfriday May 17, 2025 10:41
@bshephar

Copy link
Copy Markdown
Contributor Author

/retest

@bshephar

Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c0e85e64eafb4f9fb575fbbf086c056b

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 50m 49s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 07m 08s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 34m 14s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 15m 37s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 34m 50s
✔️ openstack-operator-docs-preview SUCCESS in 2m 12s
openstack-operator-kuttl FAILURE in 26m 49s (non-voting)

@bshephar bshephar force-pushed the imagedigestmirrorset branch from 8faed9e to ec8e8aa Compare May 22, 2025 14:27
@bshephar bshephar force-pushed the imagedigestmirrorset branch from ec8e8aa to c67c37c Compare May 30, 2025 09:45
@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1dbf441d430f4bfa8372e945961dea3b

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 03m 55s
podified-multinode-edpm-deployment-crc FAILURE in 1h 36m 08s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 41m 56s
adoption-standalone-to-crc-ceph-provider FAILURE in 1h 37m 52s
openstack-operator-tempest-multinode FAILURE in 1h 45m 40s
✔️ openstack-operator-docs-preview SUCCESS in 2m 08s

@bshephar bshephar force-pushed the imagedigestmirrorset branch from c67c37c to 2c68c9c Compare June 7, 2025 08:27
@openshift-ci openshift-ci Bot removed the approved label Jun 7, 2025
@bshephar

bshephar commented Jun 11, 2025

Copy link
Copy Markdown
Contributor Author

@stuggi @slagle Hey, can you do me a favor? Someone asked me about this on the OKO channel before I left. this should be good to go, it just needs to be pushed over the CI line. I had some issues with make bindata on my Mac, see my comment here: #1483 (comment)

I just know there was a user who needed this, so it would be nice to land and it's basically done. I can't add / remove / edit reviewers now it seems, hence my comment based ping. :)

I rebased this 4 days ago, so hopefully no new conflicts since then.

@stuggi

stuggi commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

/test all

@stuggi stuggi requested a review from slagle June 26, 2025 06:57
@bshephar bshephar force-pushed the imagedigestmirrorset branch from 2c68c9c to a17709d Compare June 26, 2025 08:39
@bshephar

Copy link
Copy Markdown
Contributor Author

/test precommit-check

@openshift-ci

openshift-ci Bot commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

@bshephar: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test precommit-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bshephar

Copy link
Copy Markdown
Contributor Author

Can someone /ok-to-test me?

@bshephar

Copy link
Copy Markdown
Contributor Author

Ok, just spinning up a Fedora container on a x86 system and I'll run make bindata from there to fix this. For some reason the MacOS one breaks, and so does Asahi... /sigh. I'll spin up that container, fix that issue and push a new revision tonight.

@stuggi

stuggi commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

Ok, just spinning up a Fedora container on a x86 system and I'll run make bindata from there to fix this. For some reason the MacOS one breaks, and so does Asahi... /sigh. I'll spin up that container, fix that issue and push a new revision tonight.

cool, thanks

@bshephar bshephar force-pushed the imagedigestmirrorset branch from a6ebed6 to f7bfdbd Compare June 26, 2025 09:31
@bshephar

Copy link
Copy Markdown
Contributor Author

/test precommit-check

This change adds support for IDMS in addition to ICSP when determining
whether the OCP cluster is in a disconnected state.

Signed-off-by: Brendan Shephard <bshephar@bne-home.net>
@bshephar bshephar force-pushed the imagedigestmirrorset branch from f7bfdbd to 8721230 Compare June 27, 2025 11:09
@bshephar

Copy link
Copy Markdown
Contributor Author

Woo, pre-commit is passing. So yeah, the solution here was to not use a Mac or a ARM architecture system. :) No idea why it generates that bindata differently even on ARM Linux. But it's passing now, just kuttl left to get working

@stuggi stuggi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgmt

@openshift-ci

openshift-ci Bot commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit c1cdd8c into openstack-k8s-operators:main Jun 28, 2025
9 checks passed
@slagle

slagle commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

/cherrypick 18.0-fr3

@openshift-cherrypick-robot

Copy link
Copy Markdown

@slagle: new pull request created: #1594

Details

In response to this:

/cherry-pick 18.0-fr3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants