Bump default memory limit for controller manager to 512Mi#1447
Conversation
In tests it was seen that the openstack-operator controller manager reaches just bellow the current set limit of 256Mi. This change bumps the default to 512Mi for all controller managers, except the openstack-operator-controller-operator which could be customized using the CSV. It also introduces a MANAGER_MEMORY_LIMIT env var in the CSV which can be used to change the memory limit of all the other controller managers. Jira: OSPRH-16802 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@stuggi should we only bump the controller-manager for openstack-operator-controller-manager which manages the largest amount or resources where we actually hit the limit. It seems like over reservation of memory for all controller managers could lead to less utilization in compact OCP clusters where we have namespace isolation. |
| memory: '{{ $managerMemoryLimit }}' | ||
| requests: | ||
| cpu: 10m | ||
| memory: 128Mi |
There was a problem hiding this comment.
@stuggi also, I think you would want to bump 'requests' too right?
|
going with #1449 for now |
2 participants
In tests it was seen that the openstack-operator controller manager reaches just bellow the current set limit of 256Mi. This change bumps the default to 512Mi for all controller managers, except the openstack-operator-controller-operator which could be customized using the CSV. It also introduces a MANAGER_MEMORY_LIMIT env var in the CSV which can be used to change the memory limit of all the other controller managers.
Jira: OSPRH-16802