Skip to content

Remove spaces on getting ISSUER details#1459

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
danpawlik:trim-value
May 29, 2025
Merged

Remove spaces on getting ISSUER details#1459
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
danpawlik:trim-value

Conversation

@danpawlik

Copy link
Copy Markdown
Contributor

It happens that the cert issuer output contains spaces, which later in the condition where it is comparing with expected issuer it just fails.

It happens that the cert issuer output contains spaces, which later
in the condition where it is comparing with expected issuer it just fails.

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
@danpawlik danpawlik requested review from abays, olliewalsh and stuggi May 28, 2025 09:54
@openshift-ci openshift-ci Bot requested review from dprince and slagle May 28, 2025 09:55
@danpawlik

Copy link
Copy Markdown
Contributor Author

Example error:

logger.go:42: 07:39:34 | ctlplane-tls-custom-issuers/2- | + echo -e 'Mismatched issuers found:
barbican-internal.openstack-kuttl-tests.svc:9311 issued by issuer=CN = rootca-internal-custom, expected issuer=CN=rootca-internal-custom
neutron-internal.openstack-kuttl-tests.svc:9696 issued by issuer=CN = rootca-internal-custom, expected issuer=CN=rootca-internal-custom
nova-internal.openstack-kuttl-tests.svc:8774 issued by issuer=CN = rootca-internal-custom, expected issuer=CN=rootca-internal-custom
cinder-internal.openstack-kuttl-tests.svc:8776 issued by issuer=CN = rootca-internal-custom, expected issuer=CN=rootca-internal-custom
swift-internal.openstack-kuttl-tests.svc:8080 issued by issuer=CN = rootca-internal-custom, expected issuer=CN=rootca-internal-custom
keystone-internal.openstack-kuttl-tests.svc:5000 issued by issuer=CN = rootca-internal-custom, expected issuer=CN=rootca-internal-custom
placement-internal.openstack-kuttl-tests.svc:8778 issued by issuer=CN = rootca-internal-custom, expected issuer=CN=rootca-internal-custom
glance-default-internal.openstack-kuttl-tests.svc:9292 issued by issuer=CN = rootca-internal-custom, expected issuer=CN=rootca-internal-custom'

@abays abays left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented May 28, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, danpawlik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi

stuggi commented May 28, 2025

Copy link
Copy Markdown
Contributor

/retest

@danpawlik

Copy link
Copy Markdown
Contributor Author

/test openstack-operator-build-deploy-kuttl

@danpawlik

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-merge-bot openshift-merge-bot Bot merged commit 3e40e32 into openstack-k8s-operators:main May 29, 2025
8 checks passed
@danpawlik danpawlik deleted the trim-value branch May 29, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants