Skip to content

Add retry on getting ISSUER name#1462

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
danpawlik:retry-getting-issuer
May 30, 2025
Merged

Add retry on getting ISSUER name#1462
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
danpawlik:retry-getting-issuer

Conversation

@danpawlik

Copy link
Copy Markdown
Contributor

It happens on some infras that the issuer is empty. Probably it does not have enough time to apply changes.
This commit adds retry for getting the ISSUER name.

@openshift-ci

openshift-ci Bot commented May 29, 2025

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@softwarefactory-project-zuul

Copy link
Copy Markdown

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/openstack-operator for 1462,4fa0cd8b373791b80423771b94ebc43926e1f568

It happens on some infras that the issuer is empty. Probably
it does not have enough time to apply changes.
This commit adds retry for getting the ISSUER name.

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
@danpawlik danpawlik force-pushed the retry-getting-issuer branch from 5bd3a7a to 07f0dd6 Compare May 29, 2025 17:32
@danpawlik danpawlik marked this pull request as ready for review May 30, 2025 10:24
@openshift-ci openshift-ci Bot requested a review from rebtoor May 30, 2025 10:24
@danpawlik

Copy link
Copy Markdown
Contributor Author
2025-05-30 10:03:22.243628 | controller |     - === NAME  kuttl
2025-05-30 10:03:22.243632 | controller |     - '    harness.go:406: run tests finished'
2025-05-30 10:03:22.243637 | controller |     - '    harness.go:514: cleaning up'
2025-05-30 10:03:22.243641 | controller |     - '    harness.go:571: removing temp folder: ""'
2025-05-30 10:03:22.243646 | controller |     - '--- PASS: kuttl (899.50s)'
2025-05-30 10:03:22.243650 | controller |     - '    --- PASS: kuttl/harness (0.00s)'
2025-05-30 10:03:22.243655 | controller |     - '        --- PASS: kuttl/harness/ctlplane-tls-custom-issuers (897.73s)'

Finally \o/

@stuggi stuggi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented May 30, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danpawlik, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit b8b9af5 into openstack-k8s-operators:main May 30, 2025
8 checks passed
@danpawlik danpawlik deleted the retry-getting-issuer branch May 30, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants