Add new update data plane service CRs into openstack-operator

[ciecierski]

Add services for edpm_update_services and edpm_update_system playbooks.[1]
For update-services EDPMServiceType add logic to indicate that minor update
is complete post service deployment, mirroring the behavior of
'update' EDPMServiceType.

Functional test for new update-service is the same as for previous
update EDPMServiceType.

OSPRH-16789

[1]openstack-k8s-operators/edpm-ansible#962

[jistr]

We should also make sure the OpenStackVersion resource considers the update finished when the update-services service has deployed. I think we need to edit this spot to make it work both with update and with update-services but not sure if there are more places to edit:

openstack-operator/controllers/dataplane/openstackdataplanenodeset_controller.go

Line 558 in 314ceec

if service.Spec.EDPMServiceType != "update" {

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0d4d4bf2916a4ab59d4d1efb7b535c09

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 27m 35s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 24m 32s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 38m 21s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 09m 15s
❌ openstack-operator-tempest-multinode FAILURE in 1h 48m 59s

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/849eb6c0a04f45bfa00e23d6cae29806

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 26m 51s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 22m 00s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 39m 16s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 10m 52s
❌ openstack-operator-tempest-multinode FAILURE in 1h 41m 13s

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5d3cfa78ca8f40988b613e806a50e38b

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 32m 14s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 38m 14s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 36m 21s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 13m 41s
❌ openstack-operator-tempest-multinode FAILURE in 1h 57m 11s

[jistr]

/lgtm

[jistr]

My review was still showing as "changes requested" but i already gave a LGTM.

[slagle]

add logic to indicate that minor update
is complete post service deployment, mirroring the behavior of
'update' EDPMServiceType.

This isn't entirely accurate in that it doesn't mirror the behavior, it's actually a change in behavior and what is being saved on the Status. Previously, we knew when both a service and system update was completed as represented by the deployed OpenStackVersion on the Status. Now we don't, so I think we need to add something in a followup.

Approving with this understanding.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciecierski, dprince, jistr, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dprince,slagle]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jistr]

The new procedure won't track the state of system update, as using our system update procedure will be optional. Admins will be free to use a different way to keep their operating system up to date, if they'd like. They operating system version will have to fit within what we consider supported.

[ciecierski]

/retest-required

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/47630ebb3f8d41be99aab925a0014539

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 48m 37s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 12m 44s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 32m 57s
❌ adoption-standalone-to-crc-ceph-provider FAILURE in 1h 31m 15s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 25m 00s

[ciecierski]

recheck

[dprince]

/lgtm