Skip to content

Add nproc equivalent for macOS#1483

Closed
ciecierski wants to merge 1 commit into
openstack-k8s-operators:mainfrom
ciecierski:num_proc_mac
Closed

Add nproc equivalent for macOS#1483
ciecierski wants to merge 1 commit into
openstack-k8s-operators:mainfrom
ciecierski:num_proc_mac

Conversation

@ciecierski

Copy link
Copy Markdown
Contributor

Add hw.logicalcpu for NUM_PROCS functional parrarel run to Makefile. hw.logicalcpu is equivalent of nproc on macOS

Add hw.logicalcpu for NUM_PROCS functional parrarel run
to Makefile. hw.logicalcpu is equivalent of nproc on
macOS
@openshift-ci openshift-ci Bot requested review from jpodivin and olliewalsh June 6, 2025 07:48
@openshift-ci

openshift-ci Bot commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ciecierski
Once this PR has been reviewed and has the lgtm label, please assign stuggi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ciecierski

Copy link
Copy Markdown
Contributor Author

/retest-required

Comment thread Makefile
NUM_PROCS := $(shell expr $(shell nproc --ignore 2) / 2)
endif
ifeq ($(UNAME_S),Darwin)
NUM_PROCS := $(shell expr $(shell sysctl -n hw.logicalcpu) / 2)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was personally just installing coreutils from homebrew, which contains nproc:

❯ nproc --ignore 2
8
❯ uname -s
Darwin

Which comes from:
https://formulae.brew.sh/formula/coreutils
https://github.com/coreutils/coreutils/blob/037b93106155c5e11681837305b541808fbdb9b5/src/nproc.c

@bshephar

bshephar commented Jun 7, 2025

Copy link
Copy Markdown
Contributor

The bigger Mac related concern for me with this repo was that bindata seemingly didn't work in pre-commit. Whenever I run pre-commit run --all-files on my Mac, it would change all the files and remove a bunch of things that seemingly shouldn't be removed.

If I just checkout main right now, and run make bindata this is all of the stuff that gets changed:
bshephar@888befa

@openshift-ci

openshift-ci Bot commented Aug 11, 2025

Copy link
Copy Markdown
Contributor

@ciecierski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl 941fc18 link true /test openstack-operator-build-deploy-kuttl
ci/prow/openstack-operator-build-deploy-kuttl-4-18 941fc18 link true /test openstack-operator-build-deploy-kuttl-4-18

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ciecierski ciecierski closed this Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants