Change RabbitmqClusterSpecCore.spec.Override to raw json type by olliewalsh · Pull Request #1501 · openstack-k8s-operators/openstack-operator

olliewalsh · 2025-06-24T13:31:18Z

Use raw json instead of nesting a giant struct.
Add webhooks to validate the override struct and warn that overriding the statefulset struct is deprecated.

Jira: OSPRH-17003

openshift-ci · 2025-06-24T13:31:23Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

softwarefactory-project-zuul · 2025-06-24T13:32:22Z

This change depends on a change that failed to merge.

Change openstack-k8s-operators/infra-operator#406 is needed.

olliewalsh · 2025-06-24T15:30:07Z

recheck

softwarefactory-project-zuul · 2025-06-24T15:37:40Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2914dcc68f13459aa7b530dfb2f456db

❌ openstack-k8s-operators-content-provider FAILURE in 5m 06s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

softwarefactory-project-zuul · 2025-07-04T14:04:23Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b39fc71197c141f29f0bdaea18ef32d6

❌ openstack-k8s-operators-content-provider FAILURE in 6m 12s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

softwarefactory-project-zuul · 2025-07-10T15:50:46Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/82329240d8b646edb2a17a0df6e87155

❌ openstack-k8s-operators-content-provider FAILURE in 5m 10s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

softwarefactory-project-zuul · 2025-07-11T17:29:01Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f2cc84b0305046759b10922f18739356

❌ openstack-k8s-operators-content-provider FAILURE in 5m 15s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

softwarefactory-project-zuul · 2025-07-11T17:54:27Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e6945a4436d74fb49af412c63dc1bb46

❌ openstack-k8s-operators-content-provider FAILURE in 5m 03s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

softwarefactory-project-zuul · 2025-07-11T18:58:34Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ddab6c9ab50a488db1ade0fb63a69ce5

❌ openstack-k8s-operators-content-provider FAILURE in 5m 17s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

softwarefactory-project-zuul · 2025-07-14T14:36:07Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/47322a04c08245b2aa6e35370ee04253

❌ openstack-k8s-operators-content-provider FAILURE in 5m 06s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

olliewalsh · 2025-07-14T16:14:02Z

recheck

softwarefactory-project-zuul · 2025-07-14T16:27:12Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2fc9cbd82a6e4c388b3f441359cd58a1

❌ openstack-k8s-operators-content-provider FAILURE in 11m 45s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

olliewalsh · 2025-07-14T17:15:57Z

recheck

softwarefactory-project-zuul · 2025-07-14T17:37:27Z

This change depends on a change that failed to merge.

Change openstack-k8s-operators/infra-operator#406 is needed.

olliewalsh · 2025-07-14T17:39:47Z

recheck

softwarefactory-project-zuul · 2025-07-14T17:52:00Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ce9d7b49115a47828119f55666b58ffe

❌ openstack-k8s-operators-content-provider FAILURE in 11m 02s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

olliewalsh · 2025-07-14T17:57:26Z

recheck

softwarefactory-project-zuul · 2025-07-14T18:36:18Z

This change depends on a change that failed to merge.

Change openstack-k8s-operators/infra-operator#406 is needed.

olliewalsh · 2025-07-14T18:36:56Z

recheck

softwarefactory-project-zuul · 2025-07-14T18:45:02Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/eaa058b61d454d93be4a5bcd9ef17a90

❌ openstack-k8s-operators-content-provider FAILURE in 6m 49s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

olliewalsh · 2025-07-14T18:53:34Z

recheck

softwarefactory-project-zuul · 2025-07-14T19:01:17Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0c127b2e23e34ff282a85eb88e619d56

❌ openstack-k8s-operators-content-provider FAILURE in 6m 33s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

olliewalsh · 2025-07-14T19:07:00Z

recheck

softwarefactory-project-zuul · 2025-07-23T16:18:22Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fb717e5b1c5b437fafc860bbd35a6d7c

❌ openstack-k8s-operators-content-provider FAILURE in 5m 46s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

… type Use raw json instead of nesting a giant struct. Add webhooks to validate the override struct and warn that overriding the statefulset struct is deprecated. Jira: OSPRH-17003

olliewalsh · 2025-07-24T00:22:43Z

/override ci/prow/precommit-check

openshift-ci · 2025-07-24T00:22:48Z

@olliewalsh: Overrode contexts on behalf of olliewalsh: ci/prow/precommit-check

Details

In response to this:

/override ci/prow/precommit-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

softwarefactory-project-zuul · 2025-07-24T00:48:47Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d18e4e068a964ee6bc675f50f52a53d1

✔️ openstack-k8s-operators-content-provider SUCCESS in 59m 53s
❌ podified-multinode-edpm-deployment-crc FAILURE in 32m 28s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 22m 09s
❌ adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 34m 53s
❌ openstack-operator-tempest-multinode FAILURE in 37m 16s

stuggi · 2025-07-24T07:07:25Z

/retest

stuggi · 2025-07-24T07:31:51Z

zuul checks failed with:

2025-07-24T00:28:06.263Z	ERROR	failed applying Operator manifests	{"error": "failed to render openstack-operator - operator: error rendering manifests: failed to render manifest /bindata/operator/rabbit.yaml: template: /bindata/operator/rabbit.yaml:42:37: executing \"/bindata/operator/rabbit.yaml\" at <.RabbitmqOperator.Deployment.Manager.Resources.Limits.CPU>: nil pointer evaluating *operator.ResourceList.CPU", "errorVerbose": "template: /bindata/operator/rabbit.yaml:42:37: executing \"/bindata/operator/rabbit.yaml\" at <.RabbitmqOperator.Deployment.Manager.Resources.Limits.CPU>: nil pointer evaluating *operator.ResourceList.CPU\nfailed to render manifest /bindata/operator/rabbit.yaml\ngithub.com/openstack-k8s-operators/openstack-operator/pkg/operator/bindata.RenderTemplate\n\t/remote-source/pkg/operator/bindata/render.go:116\ngithub.com/openstack-k8s-operators/openstack-operator/pkg/operator/bindata.RenderDir.func1\n\t/remote-source/pkg/operator/bindata/render.go:51\npath/filepath.walk\n\t/usr/lib/golang/src/path/filepath/path.go:477\npath/filepath.walk\n\t/usr/lib/golang/src/path/filepath/path.go:501\npath/filepath.Walk\n\t/usr/lib/golang/src/path/filepath/path.go:572\ngithub.com/openstack-k8s-operators/openstack-operator/pkg/operator/bindata.RenderDir\n\t/remote-source/pkg/operator/bindata/render.go:38\ngithub.com/openstack-k8s-operators/openstack-operator/controllers/operator.(*OpenStackReconciler).renderAndApply\n\t/remote-source/controllers/operator/openstack_controller.go:679\ngithub.com/openstack-k8s-operators/openstack-operator/controllers/operator.(*OpenStackReconciler).applyOperator\n\t/remote-source/controllers/operator/openstack_controller.go:664\ngithub.com/openstack-k8s-operators/openstack-operator/controllers/operator.(*OpenStackReconciler).applyManifests\n\t/remote-source/controllers/operator/openstack_controller.go:474\ngithub.com/openstack-k8s-operators/openstack-operator/controllers/operator.(*OpenStackReconciler).Reconcile\n\t/remote-

the root cause is that the openstack-operator-controller-operator pod environment vars miss a lot of the service operator images
https://logserver.rdoproject.org/3d3/rdoproject.org/3d3c71ba3520446f8c0a5dafc6d0da79/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack-operators/pods/openstack-operator-controller-operator-5ffcb49cd-q6kdw/openstack-operator-controller-operator-5ffcb49cd-q6kdw-describe

it only has

      RELATED_IMAGE_BARBICAN_OPERATOR_MANAGER_IMAGE_URL:                quay.io/openstack-k8s-operators/barbican-operator@sha256:139c83dd5b4be4af14a2254c1fda5c7db9dfad36f0f158e9e3c8e0660df8ccb8
      RELATED_IMAGE_CINDER_OPERATOR_MANAGER_IMAGE_URL:                  quay.io/openstack-k8s-operators/cinder-operator@sha256:8a92e1b6c6f6f56e5adc9dd5ce7cc3a970a09087fe783536af0cf5d1b937d98b
      RELATED_IMAGE_DESIGNATE_OPERATOR_MANAGER_IMAGE_URL:               quay.io/openstack-k8s-operators/designate-operator@sha256:82f998868160c5d0e319c631117a7e727140bb3a85456d7423635cb37afa91bb
      RELATED_IMAGE_GLANCE_OPERATOR_MANAGER_IMAGE_URL:                  quay.io/openstack-k8s-operators/glance-operator@sha256:684881c48415a3c7698dde3549f7ea5e4eda0eb3be416ccc77e935abaec94567
      RELATED_IMAGE_HEAT_OPERATOR_MANAGER_IMAGE_URL:                    quay.io/openstack-k8s-operators/heat-operator@sha256:e98bc8cb6f92d0fe5188e24b565fe86c89bb74fa0b37015b55ddc00c5db26c9f

lets recheck to see if it happens again

stuggi · 2025-07-24T07:32:07Z

recheck

stuggi

/lgtm

openshift-ci · 2025-07-24T11:57:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olliewalsh, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [olliewalsh,stuggi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

olliewalsh requested review from abays, dprince and stuggi June 24, 2025 13:31

openshift-ci Bot added the do-not-merge/work-in-progress label Jun 24, 2025

openshift-ci Bot added the approved label Jun 24, 2025

openshift-merge-robot added the needs-rebase label Jun 27, 2025

olliewalsh force-pushed the rabbitmq_trim branch from 266bf71 to 28879e4 Compare July 4, 2025 13:57

openshift-merge-robot removed the needs-rebase label Jul 4, 2025

olliewalsh force-pushed the rabbitmq_trim branch from 28879e4 to 6100a85 Compare July 10, 2025 15:43

olliewalsh force-pushed the rabbitmq_trim branch from 6f7995d to a4a92dc Compare July 11, 2025 18:52

olliewalsh force-pushed the rabbitmq_trim branch from a4a92dc to 9b7ced1 Compare July 14, 2025 14:29

olliewalsh mentioned this pull request Jul 16, 2025

Fix rabbitmq-cluster-operator depends-on openstack-k8s-operators/ci-framework#3125

Merged

olliewalsh force-pushed the rabbitmq_trim branch from 9b7ced1 to 0cdb45a Compare July 23, 2025 16:10

olliewalsh marked this pull request as ready for review July 23, 2025 16:11

openshift-ci Bot removed the do-not-merge/work-in-progress label Jul 23, 2025

olliewalsh force-pushed the rabbitmq_trim branch from 0cdb45a to ce8588e Compare July 23, 2025 16:12

Change RabbitmqClusterSpecCore.Spec.Override.StatefuleSet to raw json…

252cfd8

… type Use raw json instead of nesting a giant struct. Add webhooks to validate the override struct and warn that overriding the statefulset struct is deprecated. Jira: OSPRH-17003

olliewalsh force-pushed the rabbitmq_trim branch from ce8588e to 252cfd8 Compare July 23, 2025 23:46

stuggi approved these changes Jul 24, 2025

View reviewed changes

openshift-ci Bot assigned stuggi Jul 24, 2025

openshift-ci Bot added the lgtm label Jul 24, 2025

openshift-merge-bot Bot merged commit e3521a8 into openstack-k8s-operators:main Jul 24, 2025
11 checks passed

Conversation

olliewalsh commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Jun 24, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Jun 24, 2025

Uh oh!

olliewalsh commented Jun 24, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Jun 24, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Jul 4, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Jul 10, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Jul 11, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Jul 11, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Jul 11, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Jul 14, 2025

Uh oh!

olliewalsh commented Jul 14, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Jul 14, 2025

Uh oh!

olliewalsh commented Jul 14, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Jul 14, 2025

Uh oh!

olliewalsh commented Jul 14, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Jul 14, 2025

Uh oh!

olliewalsh commented Jul 14, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Jul 14, 2025

Uh oh!

olliewalsh commented Jul 14, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Jul 14, 2025

Uh oh!

olliewalsh commented Jul 14, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Jul 14, 2025

Uh oh!

olliewalsh commented Jul 14, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Jul 23, 2025

Uh oh!

olliewalsh commented Jul 24, 2025

Uh oh!

openshift-ci Bot commented Jul 24, 2025

Uh oh!

softwarefactory-project-zuul Bot commented Jul 24, 2025

Uh oh!

stuggi commented Jul 24, 2025

Uh oh!

stuggi commented Jul 24, 2025

Uh oh!

stuggi commented Jul 24, 2025

Uh oh!

stuggi left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Jul 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

olliewalsh commented Jun 24, 2025 •

edited

Loading