Check if OctaviaRsyslogImage is not nil#1503
Conversation
OctaviaRsyslog was introduced in FR2 time frame. If there is an update with enabled octavia from before, the current targetVerion images won't have an OctaviaRsyslogImage which results in a nil ptr dereference error and the controller manage panics. This adds a check, like done in other places if the images is non nil and otherwise falls back to an empty string. Jira: OSPRH-17647 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick 18.0-fr3 |
|
@stuggi: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
Bot
merged commit 3307ee4
into
openstack-k8s-operators:main
|
@stuggi: new pull request created: #1504 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
OctaviaRsyslog was introduced in FR2 time frame. If there is an update with enabled octavia from before, the current targetVerion images won't have an OctaviaRsyslogImage which results in a nil ptr dereference error and the controller manage panics.
This adds a check, like done in other places if the images is non nil and otherwise falls back to an empty string.
Jira: OSPRH-17647