Skip to content

Use structured logging#1536

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
ratailor:fix-logger
Jul 29, 2025
Merged

Use structured logging#1536
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
ratailor:fix-logger

Conversation

@ratailor

@ratailor ratailor commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

This change uses GetLogger instead of direct use of log.FromContext to support structured logging.

@openshift-ci openshift-ci Bot requested review from dprince and rebtoor July 17, 2025 12:18
@ratailor ratailor force-pushed the fix-logger branch 2 times, most recently from 4840914 to 3e4c5c7 Compare July 21, 2025 07:29
@ratailor

ratailor commented Jul 22, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@ratailor
Use structured logging
5a198f0 
This change uses GetLogger instead of direct use of
log.FromContext to support structured logging.
@softwarefactory-project-zuul

softwarefactory-project-zuul Bot commented Jul 22, 2025

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6799a7a3a7d44f96bcd462cbc4ff3af3

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 48m 07s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 48s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 33m 45s
❌ adoption-standalone-to-crc-ceph-provider FAILURE in 1h 25m 50s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 27m 10s

@ratailor

ratailor commented Jul 23, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@ratailor

ratailor commented Jul 23, 2025

Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul

softwarefactory-project-zuul Bot commented Jul 23, 2025

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/734c1683d1e4481b91097afc09b6c9d3

❌ openstack-k8s-operators-content-provider FAILURE in 5m 48s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@ratailor

ratailor commented Jul 23, 2025

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@ratailor

ratailor commented Jul 25, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@ratailor

ratailor commented Jul 28, 2025

Copy link
Copy Markdown
Contributor Author

recheck

@ratailor ratailor requested review from abays and stuggi July 29, 2025 05:40
stuggi
stuggi approved these changes Jul 29, 2025
View reviewed changes

@stuggi stuggi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jul 29, 2025
@openshift-ci

openshift-ci Bot commented Jul 29, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ratailor, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit a2af118 into openstack-k8s-operators:main Jul 29, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuggi stuggi stuggi approved these changes

@dprince dprince Awaiting requested review from dprince

@rebtoor rebtoor Awaiting requested review from rebtoor

@abays abays Awaiting requested review from abays

Assignees

@stuggi stuggi

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ratailor @stuggi