Make script input vars mandatory#1539
Merged
openshift-merge-bot[bot] merged 1 commit intoJul 23, 2025
Merged
Conversation
Make MAIN_VERSION, FEATURE_RELEASE_VERSION, and FEATURE_RELEASE_BRANCH mandatory. When run via the job, those vars get set in the workflow [1]. Lets make them mandatory, instead of bumping them in the workflow and the script on a new feature branch. If run manually they should be set. [1] https://github.com/openstack-k8s-operators/openstack-operator/blob/5f8fbc7cd3b79a363d9fc2016e6e3c5b239b4d5a/.github/workflows/catalog-openstack-operator-upgrades.yaml#L68 Jira: OSPRH-18397 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
stuggi
added a commit
to stuggi/openstack-k8s-operators-ci
that referenced
this pull request
Jul 22, 2025
This workflow takes the following inputs: * BRANCH_NAME - release branch name, e.g. 18.0-fr4 * NEW_VERSION - The new version to set in the Makefile on the main/source branch, e.g. 0.5 * FORCE_BUMP_BRANCHES - The new list of branches for the force-bump-branches.yaml workflow, e.g. ["main", "18.0-fr3"] * DRY_RUN - Bool to run in Dry mode to not push changes This workflow does the following tasks: - BRANCH_NAME updates: * checks every repository in the org for an olive branch. If it exists, the new BRANCH_NAME gets created from main * each Makefile of the BRANCH_NAME, the Makefile gets updated to set the feature branch * in case of install_yamls, the OPENSTACK_K8S_TAG gets updated in the Makefile for the feature branch - openstack-operator main branch updates: * Updates Makefile to reflect the NEW_VERSION * updates hack/fake_minor_update.sh for the NEW_VERSION * updates .github/workflows/catalog-openstack-operator-upgrades.yaml for the version change - Update openstack-k8s-operators-ci workflows * updates .github/workflows/release-branch-sync.yaml for the new BRANCH_NAME * updates .github/workflows/force-bump-branches.yaml for the new FORCE_BUMP_BRANCHES - Add rabbitmq-cluster-operator-index tag for the branch * calls .github/workflows/rabbitmq-cluster-operator-index-feature-tag.yaml to push a new tag for the BRANCHE_NAME Note: this workflow requires authentication using a GitHub App with permissions to read/write content of the repos and workflows. Depends-On: openstack-k8s-operators#135 Depends-On: openstack-k8s-operators/openstack-operator#1539 Depends-On: openstack-k8s-operators/openstack-operator#1540 Jira: OSPRH-18397 Assisted-by: gemini Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/openstack-k8s-operators-ci
that referenced
this pull request
Jul 22, 2025
This workflow takes the following inputs: * BRANCH_NAME - release branch name, e.g. 18.0-fr4 * NEW_VERSION - The new version to set in the Makefile on the main/source branch, e.g. 0.5 * FORCE_BUMP_BRANCHES - The new list of branches for the force-bump-branches.yaml workflow, e.g. ["main", "18.0-fr3"] * DRY_RUN - Bool to run in Dry mode to not push changes This workflow does the following tasks: - BRANCH_NAME updates: * checks every repository in the org for an olive branch. If it exists, the new BRANCH_NAME gets created from main * each Makefile of the BRANCH_NAME, the Makefile gets updated to set the feature branch * in case of install_yamls, the OPENSTACK_K8S_TAG gets updated in the Makefile for the feature branch - openstack-operator main branch updates: * Updates Makefile to reflect the NEW_VERSION * updates hack/fake_minor_update.sh for the NEW_VERSION * updates .github/workflows/catalog-openstack-operator-upgrades.yaml for the version change - Update openstack-k8s-operators-ci workflows * updates .github/workflows/release-branch-sync.yaml for the new BRANCH_NAME * updates .github/workflows/force-bump-branches.yaml for the new FORCE_BUMP_BRANCHES - Add rabbitmq-cluster-operator-index tag for the branch * calls .github/workflows/rabbitmq-cluster-operator-index-feature-tag.yaml to push a new tag for the BRANCHE_NAME Note: this workflow requires authentication using a GitHub App with permissions to read/write content of the repos and workflows. Depends-On: openstack-k8s-operators#135 Depends-On: openstack-k8s-operators/openstack-operator#1539 Depends-On: openstack-k8s-operators/openstack-operator#1540 Jira: OSPRH-18397 Assisted-by: gemini Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/openstack-k8s-operators-ci
that referenced
this pull request
Jul 22, 2025
This workflow takes the following inputs: * BRANCH_NAME - release branch name, e.g. 18.0-fr4 * NEW_VERSION - The new version to set in the Makefile on the main/source branch, e.g. 0.5 * FORCE_BUMP_BRANCHES - The new list of branches for the force-bump-branches.yaml workflow, e.g. ["main", "18.0-fr3"] * DRY_RUN - Bool to run in Dry mode to not push changes This workflow does the following tasks: - BRANCH_NAME updates: * checks every repository in the org for an olive branch. If it exists, the new BRANCH_NAME gets created from main * each Makefile of the BRANCH_NAME, the Makefile gets updated to set the feature branch * in case of install_yamls, the OPENSTACK_K8S_TAG gets updated in the Makefile for the feature branch - openstack-operator main branch updates: * Updates Makefile to reflect the NEW_VERSION * updates hack/fake_minor_update.sh for the NEW_VERSION * updates .github/workflows/catalog-openstack-operator-upgrades.yaml for the version change - Update openstack-k8s-operators-ci workflows * updates .github/workflows/release-branch-sync.yaml for the new BRANCH_NAME * updates .github/workflows/force-bump-branches.yaml for the new FORCE_BUMP_BRANCHES - Add rabbitmq-cluster-operator-index tag for the branch * calls .github/workflows/rabbitmq-cluster-operator-index-feature-tag.yaml to push a new tag for the BRANCHE_NAME Note: this workflow requires authentication using a GitHub App with permissions to read/write content of the repos and workflows. Depends-On: openstack-k8s-operators#135 Depends-On: openstack-k8s-operators/openstack-operator#1539 Depends-On: openstack-k8s-operators/openstack-operator#1540 Jira: OSPRH-18397 Assisted-by: gemini Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 696ef43
into
openstack-k8s-operators:main
10 checks passed
stuggi
added a commit
to stuggi/openstack-k8s-operators-ci
that referenced
this pull request
Jul 23, 2025
This workflow takes the following inputs: * BRANCH_NAME - release branch name, e.g. 18.0-fr4 * NEW_VERSION - The new version to set in the Makefile on the main/source branch, e.g. 0.5 * FORCE_BUMP_BRANCHES - The new list of branches for the force-bump-branches.yaml workflow, e.g. ["main", "18.0-fr3"] * DRY_RUN - Bool to run in Dry mode to not push changes This workflow does the following tasks: - BRANCH_NAME updates: * checks every repository in the org for an olive branch. If it exists, the new BRANCH_NAME gets created from main * each Makefile of the BRANCH_NAME, the Makefile gets updated to set the feature branch * in case of install_yamls, the OPENSTACK_K8S_TAG gets updated in the Makefile for the feature branch - openstack-operator main branch updates: * Updates Makefile to reflect the NEW_VERSION * updates hack/fake_minor_update.sh for the NEW_VERSION * updates .github/workflows/catalog-openstack-operator-upgrades.yaml for the version change - Update openstack-k8s-operators-ci workflows * updates .github/workflows/release-branch-sync.yaml for the new BRANCH_NAME * updates .github/workflows/force-bump-branches.yaml for the new FORCE_BUMP_BRANCHES - Add rabbitmq-cluster-operator-index tag for the branch * calls .github/workflows/rabbitmq-cluster-operator-index-feature-tag.yaml to push a new tag for the BRANCHE_NAME Note: this workflow requires authentication using a GitHub App with permissions to read/write content of the repos and workflows. Depends-On: openstack-k8s-operators#135 Depends-On: openstack-k8s-operators/openstack-operator#1539 Depends-On: openstack-k8s-operators/openstack-operator#1540 Jira: OSPRH-18397 Assisted-by: gemini Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
added a commit
to stuggi/openstack-k8s-operators-ci
that referenced
this pull request
Jul 30, 2025
This workflow takes the following inputs: * BRANCH_NAME - release branch name, e.g. 18.0-fr4 * NEW_VERSION - The new version to set in the Makefile on the main/source branch, e.g. 0.5 * FORCE_BUMP_BRANCHES - The new list of branches for the force-bump-branches.yaml workflow, e.g. ["main", "18.0-fr3"] * DRY_RUN - Bool to run in Dry mode to not push changes * CREATE_RELEASE_BRANCHES - Bool to control branch creation step * UPDATE_OPENSTACK_OPERATOR - Bool to control openstack-operator updates * UPDATE_CI_WORKFLOWS - Bool to control CI workflow updates * RETAG_RABBITMQ_OPERATOR - Bool to control rabbitmq retagging job This workflow does the following tasks: - BRANCH_NAME updates: * checks every repository in the org for an olive branch. If it exists, the new BRANCH_NAME gets created from main * each Makefile of the BRANCH_NAME, the Makefile gets updated to set the feature branch * in case of install_yamls, the OPENSTACK_K8S_TAG gets updated in the Makefile for the feature branch - openstack-operator main branch updates: * Updates Makefile to reflect the NEW_VERSION * updates hack/fake_minor_update.sh for the NEW_VERSION * updates .github/workflows/catalog-openstack-operator-upgrades.yaml for the version change - Update openstack-k8s-operators-ci workflows * updates .github/workflows/release-branch-sync.yaml for the new BRANCH_NAME * updates .github/workflows/force-bump-branches.yaml for the new FORCE_BUMP_BRANCHES - Add rabbitmq-cluster-operator-index tag for the branch * calls .github/workflows/rabbitmq-cluster-operator-index-feature-tag.yaml to push a new tag for the BRANCHE_NAME Note: this workflow requires authentication using a GitHub App with permissions to read/write content of the repos and workflows. Depends-On: openstack-k8s-operators#135 Depends-On: openstack-k8s-operators/openstack-operator#1539 Depends-On: openstack-k8s-operators/openstack-operator#1540 Jira: OSPRH-18397 Assisted-by: gemini Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make MAIN_VERSION, FEATURE_RELEASE_VERSION, and FEATURE_RELEASE_BRANCH mandatory.
When run via the job, those vars get set in the workflow [1]. Lets make them mandatory, instead of bumping them in the workflow and the script on a new feature branch. If run manually they should be set.
[1]
openstack-operator/.github/workflows/catalog-openstack-operator-upgrades.yaml
Line 68 in 5f8fbc7
Jira: OSPRH-18397