[bindata] catch skopeo copy failures

[olliewalsh]

If skopeo copy failed (e.g quay.io wobbling) it would be silently ignored and result in missing image references

[olliewalsh]

If I change the skopeo command to false:

+ for BUNDLE in $(hack/pin-bundle-images.sh | tr "," " ")
+ set +e
+ n=0
+ RC=1
+ :
+ false
+ RC=1
+ '[' 1 -eq 0 -o 0 -ge 5 ']'
+ n=1
+ echo 'Command failed. retrying ... 1/5'
Command failed. retrying ... 1/5
+ sleep 15
+ :
+ false
+ RC=1
+ '[' 1 -eq 0 -o 1 -ge 5 ']'
+ n=2
+ echo 'Command failed. retrying ... 2/5'
Command failed. retrying ... 2/5
+ sleep 15
+ :
+ false
+ RC=1
+ '[' 1 -eq 0 -o 2 -ge 5 ']'
+ n=3
+ echo 'Command failed. retrying ... 3/5'
Command failed. retrying ... 3/5
+ sleep 15
+ :
+ false
+ RC=1
+ '[' 1 -eq 0 -o 3 -ge 5 ']'
+ n=4
+ echo 'Command failed. retrying ... 4/5'
Command failed. retrying ... 4/5
+ sleep 15
+ :
+ false
+ RC=1
+ '[' 1 -eq 0 -o 4 -ge 5 ']'
+ n=5
+ echo 'Command failed. retrying ... 5/5'
Command failed. retrying ... 5/5
+ sleep 15
+ :
+ false
+ RC=1
+ '[' 1 -eq 0 -o 5 -ge 5 ']'
+ exit 1
make: *** [Makefile:162: bindata] Error 1

[stuggi]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olliewalsh, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [olliewalsh,stuggi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[stuggi]

/retest

[stuggi]

/retest

[stuggi]

/cherry-pick 18.0-fr3

[openshift-cherrypick-robot]

@stuggi: once the present PR merges, I will cherry-pick it on top of 18.0-fr3 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick 18.0-fr3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[olliewalsh]

/test openstack-operator-build-deploy-kuttl

[openshift-cherrypick-robot]

@stuggi: new pull request created: #1546

Details

In response to this:

/cherry-pick 18.0-fr3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.