Skip to content

[golang] bump to golang 1.24#1567

Merged
openshift-merge-bot[bot] merged 5 commits into
openstack-k8s-operators:mainfrom
stuggi:golang_1.24
Sep 22, 2025
Merged

[golang] bump to golang 1.24#1567
openshift-merge-bot[bot] merged 5 commits into
openstack-k8s-operators:mainfrom
stuggi:golang_1.24

Conversation

@stuggi

@stuggi stuggi commented Aug 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • bump in go.mod (base and api)
  • bump go-toolset in Dockerfile
  • bump golang version and custom_image in github jobs ('.github/workflows')
  • Bump the golangci-lint version in the .pre-commit-config.yaml to v2.4.0
  • Bump build_root_image in .ci-operator.yaml to ci-build-root-golang-1.24-sdk-1.31 (if set)

Also bump dependencies for OpenShift 4.18. Update controller-runtime, Kubernetes dependencies, and testing tools to support OpenShift Container Platform 4.18 (Kubernetes 1.31):

  • controller-runtime: v0.17.6 → v0.19.7
  • Kubernetes core dependencies: v0.29.15 → v0.31.12
    • k8s.io/api: v0.31.12
    • k8s.io/apimachinery: v0.31.12
    • k8s.io/client-go: v0.31.12
    • k8s.io/apiextensions-apiserver: v0.31.12
  • k8s.io/utils: v0.0.0-20240711033017 → v0.0.0-20250820121507
  • controller-gen: v0.14.0 → v0.18.0
  • envtest: 1.29 → 1.31.0, setup-envtest@latest

To test on existing env, or after landed:

  • update golang to 1.24
  • delete current go.work* files
  • init go work files go work init
  • Delete tools in bin/ subdir of the repo

Depends-On: openstack-k8s-operators/install_yamls#1082

Jira: OSPRH-12935

@openshift-ci openshift-ci Bot requested review from rebtoor and viroel August 18, 2025 15:11
@stuggi stuggi mentioned this pull request Aug 18, 2025
Merged
@stuggi stuggi changed the title [golang] bump to golang 1.23 [golang] bump to golang 1.24 Aug 18, 2025
This was referenced Aug 18, 2025
Closed
Closed
@softwarefactory-project-zuul

softwarefactory-project-zuul Bot commented Aug 18, 2025

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a140f826ccfd47c98120c543863c6b39

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 32m 00s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 08m 48s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 31m 51s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 16s
❌ adoption-standalone-to-crc-ceph-provider FAILURE in 2h 16m 20s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 35m 20s

This was referenced Aug 19, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@softwarefactory-project-zuul

softwarefactory-project-zuul Bot commented Sep 16, 2025

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/eb7a3bea1f86493c945dfbc6d5746e19

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 16m 18s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 47m 44s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 32m 17s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 41s
❌ adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 2h 02m 30s
❌ openstack-operator-tempest-multinode FAILURE in 1h 54m 30s

@softwarefactory-project-zuul

softwarefactory-project-zuul Bot commented Sep 16, 2025

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8979450859ca4445b1a989e5feb435e2

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 25m 36s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 21m 58s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 28m 19s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 38s
❌ adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 32m 41s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 38m 57s

@stuggi

stuggi commented Sep 17, 2025

Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul

softwarefactory-project-zuul Bot commented Sep 17, 2025

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/291bb35c4ab44d17b0d425e36db947e5

❌ openstack-k8s-operators-content-provider POST_FAILURE in 2h 02m 09s
❌ podified-multinode-edpm-deployment-crc POST_FAILURE in 1h 21m 45s
❌ cifmw-crc-podified-edpm-baremetal POST_FAILURE in 1h 23m 50s
❌ cifmw-pod-zuul-files POST_FAILURE in 4m 23s
❌ adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 29m 23s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 42m 54s

@stuggi stuggi mentioned this pull request Sep 17, 2025
Merged
@softwarefactory-project-zuul

softwarefactory-project-zuul Bot commented Sep 18, 2025

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6eb365f4595f4591ba808dad72637381

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 54m 05s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 22m 30s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 37m 21s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 14s
❌ adoption-standalone-to-crc-ceph-provider FAILURE in 1h 31m 16s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 37m 40s

@stuggi

stuggi commented Sep 18, 2025

Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul

softwarefactory-project-zuul Bot commented Sep 18, 2025

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/385d891c52a0483a92c6f68a28967adb

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 07m 44s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 24m 02s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 27m 53s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 31s
❌ adoption-standalone-to-crc-ceph-provider FAILURE in 1h 32m 26s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 42m 10s

@stuggi stuggi mentioned this pull request Sep 19, 2025
Merged
@stuggi
bump to golang 1.24
8a7f47b 
* bump in go.mod (base and api)
* bump go-toolset in Dockerfile
* bump golang version and custom_iamge in github jobs ('.github/workflows')
* Bump the golangci-lint version in the .pre-commit-config.yaml to v2.4.0
* Bump build_root_image in .ci-operator.yaml to ci-build-root-golang-1.24-sdk-1.31

Also fixes golangci-lint reported issues for new v2.4.0 version.

Jira: OSPRH-12935

Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
@stuggi
[golang] replace "golang.org/x/exp/slices" with stdlib one
f804ccb 
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
@stuggi
Bump dependencies for OpenShift 4.18 compatibility
6292ce5 
Update controller-runtime, Kubernetes dependencies, and testing tools
to support OpenShift Container Platform 4.18 (Kubernetes 1.31).

Changes:
- controller-runtime: v0.17.6 → v0.19.7
- Kubernetes core dependencies: v0.29.15 → v0.31.12
  * k8s.io/api: v0.31.12
  * k8s.io/apimachinery: v0.31.12
  * k8s.io/client-go: v0.31.12
  * k8s.io/apiextensions-apiserver: v0.31.12
- k8s.io/utils: v0.0.0-20240711033017 → v0.0.0-20250820121507
- controller-gen: v0.14.0 → v0.18.0
- envtest: 1.29 → 1.31, setup-envtest@latest

Depends-On: openstack-k8s-operators/infra-operator#432

Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
@stuggi
[test] validate Spec.TLS is not nil before assert
732e37d 
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
@stuggi
bump lib-common
69c37f9 
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
@softwarefactory-project-zuul

softwarefactory-project-zuul Bot commented Sep 22, 2025

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/de4e849b389a440a836f7e87fcbb582b

❌ openstack-k8s-operators-content-provider RETRY_LIMIT in 45s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ cifmw-pod-zuul-files SUCCESS in 4m 33s
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@stuggi

stuggi commented Sep 22, 2025

Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul

softwarefactory-project-zuul Bot commented Sep 22, 2025

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f290312e61154cbd9f2f4ade11aac1c0

❌ openstack-k8s-operators-content-provider RETRY_LIMIT in 49s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ cifmw-pod-zuul-files SUCCESS in 4m 31s
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@stuggi

stuggi commented Sep 22, 2025

Copy link
Copy Markdown
Contributor Author

recheck

@stuggi stuggi requested a review from abays September 22, 2025 10:54
@openshift-ci openshift-ci Bot added the lgtm label Sep 22, 2025
@openshift-ci

openshift-ci Bot commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit e3a0bb3 into openstack-k8s-operators:main Sep 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gibizer gibizer gibizer left review comments

@dprince dprince dprince approved these changes

@abays abays Awaiting requested review from abays

Assignees

@dprince dprince

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stuggi @dprince @gibizer @openshift-merge-robot