Make local webhook port configurable#1590
Conversation
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e3ef1b20e0054795a8f44331f14e0f8f ❌ openstack-k8s-operators-content-provider FAILURE in 10m 33s |
karelyatin
force-pushed
the
custom_webhook_port
branch
from
6e1de34 to
c3dd6bb
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8e95c296c86d4683b37abb9345bb916d ❌ openstack-k8s-operators-content-provider FAILURE in 10m 36s |
Will be helpful when running multiple operators locally
karelyatin
force-pushed
the
custom_webhook_port
branch
from
c3dd6bb to
52187f2
Compare
| TMPDIR=${TMPDIR:-"/tmp/k8s-webhook-server/serving-certs"} | ||
| SKIP_CERT=${SKIP_CERT:-false} | ||
| CRC_IP=${CRC_IP:-$(/sbin/ip -o -4 addr list crc | awk '{print $4}' | cut -d/ -f1)} | ||
| WEBHOOK_PORT=${WEBHOOK_PORT:-${WEBHOOK_PORT}} |
There was a problem hiding this comment.
Should this use the format you used here [1] instead?
There was a problem hiding this comment.
actually i changed it all the repos by keeping the port define only at one place in Makefile
There was a problem hiding this comment.
And we don't expect anyone to use this script directly outside of calling it from the Makefile target (which sets the default), so this seems fine.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, karelyatin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 34b854d
into
openstack-k8s-operators:main
2 participants
Will be helpful when running multiple operators locally