[OSPRH-19707] Prioritize surfacing warn/error severity sub-statuses#1596
Conversation
olliewalsh
left a comment
olliewalsh
left a comment
There was a problem hiding this comment.
minor nit, otherwise LGTM
| condition.RequestedReason, | ||
| condition.SeverityInfo, | ||
| corev1beta1.OpenStackControlPlaneOVNReadyRunningMessage)) | ||
| // We want to mirror the condition of the highest priority from the OVN resources into the instance |
There was a problem hiding this comment.
on line 70 log message is "OVN is ready", to be consistent should that change to "OVN ready condition is true"?
There was a problem hiding this comment.
@olliewalsh Just discovered that I missed the Galera processing logic. Going to fix that too before we merge.
There was a problem hiding this comment.
All changes made. Also improved the Redis logic along with adding Galera and fixing the OVN nit.
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9204559dd3cf485db2db386c2afb7b4e ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 23m 43s |
EDPM bootstrap job failure, unrelated to PR: |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1a7b321514924bb9991fe0cb63ec0d09 ✔️ openstack-k8s-operators-content-provider SUCCESS in 4h 56m 01s |
Same error as last time: I can't see how a failing EDPM |
|
recheck |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
recheck |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Missed |
🤦♂️ /test openstack-operator-build-deploy-kuttl |
|
/test openstack-operator-build-deploy-kuttl |
🤦♂️ /test openstack-operator-build-deploy-kuttl |
😠 /test openstack-operator-build-deploy-kuttl |
😖 /test openstack-operator-build-deploy-kuttl |
Add MirrorSubResourceCondition calls across all OpenStack service reconcilers to enable proper condition hierarchy and severity-based prioritization in the OpenStackControlPlane's "Ready" condition. Key changes: - Add MirrorSubResourceCondition calls for better condition propagation from sub-resources to OpenStackControlPlane instance - Ensure higher severity conditions (warn/error) are properly surfaced in 'oc get osctlplane' output instead of being overwritten by later info-level events This addresses the core issue where the last-processed sub-resource condition would overwrite higher-severity conditions from earlier in the reconcile loop, ensuring critical conditions are properly prioritized and visible. Files modified: pkg/openstack/common.go and all 20 OpenStack service reconcilers (keystone.go, barbican.go, cinder.go, glance.go, nova.go, neutron.go, etc.) Related to: https://issues.redhat.com/browse/OSPRH-19707 Co-authored-by: Claude <claude@anthropic.com>
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6fa12437c6134f5a88e63ea282a389ec ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 19m 47s |
|
recheck |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit ed564ce
into
openstack-k8s-operators:main
Got incorrectly lost as part of [1]. [1] openstack-k8s-operators#1596 Related-Issue: https://issues.redhat.com/browse/OSPRH-12568
| instance.Spec.Ovn.Template.OVNNorthd.DeepCopyInto(&OVNNorthd.Spec.OVNNorthdSpecCore) | ||
|
|
||
| OVNNorthd.Spec.ContainerImage = *version.Status.ContainerImages.OvnNorthdImage | ||
| OVNNorthd.Spec.ExporterImage = *getImg(version.Status.ContainerImages.OpenstackNetworkExporterImage, &missingImageDefault) |
There was a problem hiding this comment.
this was incorrectly dropped, fixing with #1618
5 participants
Add MirrorSubResourceCondition calls across all OpenStack service reconcilers to enable proper condition hierarchy and severity-based prioritization in the OpenStackControlPlane's "Ready" condition.
Key changes:
This addresses the core issue where the last-processed sub-resource condition would overwrite higher-severity conditions from earlier in the reconcile loop, ensuring critical conditions are properly prioritized and visible.
Files modified: pkg/openstack/common.go and all 20 OpenStack service reconcilers (keystone.go, barbican.go, cinder.go, glance.go, nova.go, neutron.go, etc.)
Related to: https://issues.redhat.com/browse/OSPRH-19707
Co-authored-by: Claude claude@anthropic.com