[OSPRH-19828] Improve consistency of condition severity usage

[abays]

First pass of trying to achieve greater consistency of condition Severity across all our operators.

Jira: https://issues.redhat.com/browse/OSPRH-19828

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/217ef7ffea584648be359ef4af798442

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 19m 57s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 10m 34s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 26m 46s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 05m 28s
❌ openstack-operator-tempest-multinode FAILURE in 1h 53m 31s

[abays]

@abays: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl 376aad8 link true /test openstack-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

{  failed to wait for the created cluster claim to become ready: timed out waiting for the condition}

😖

/test openstack-operator-build-deploy-kuttl

[abays]

@abays: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl 376aad8 link true /test openstack-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

{  failed to wait for the created cluster claim to become ready: timed out waiting for the condition}

🙄

/test openstack-operator-build-deploy-kuttl

[stuggi]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [abays,stuggi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abays]

@abays: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl 376aad8 link unknown /test openstack-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

{  failed to wait for the created cluster claim to become ready: timed out waiting for the condition}

Surely you can't be serious. Again?!

/test openstack-operator-build-deploy-kuttl

[abays]

@abays: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl 376aad8 link true /test openstack-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

{  failed to wait for the created cluster claim to become ready: timed out waiting for the condition}

😡

/test openstack-operator-build-deploy-kuttl

[abays]

/cherry-pick 18.0-fr3

[openshift-cherrypick-robot]

@abays: #1599 failed to apply on top of branch "18.0-fr3":

Applying: Improve consistency of condition severity usage
Using index info to reconstruct a base tree...
M	controllers/client/openstackclient_controller.go
M	controllers/core/openstackversion_controller.go
M	controllers/dataplane/openstackdataplanenodeset_controller.go
M	pkg/dataplane/ipam.go
M	pkg/openstack/common.go
M	pkg/openstack/version.go
M	tests/functional/ctlplane/openstackoperator_controller_test.go
M	tests/functional/ctlplane/openstackversion_controller_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/functional/ctlplane/openstackversion_controller_test.go
Auto-merging tests/functional/ctlplane/openstackoperator_controller_test.go
Auto-merging pkg/openstack/version.go
CONFLICT (content): Merge conflict in pkg/openstack/version.go
Auto-merging pkg/openstack/common.go
Auto-merging pkg/dataplane/ipam.go
Auto-merging controllers/dataplane/openstackdataplanenodeset_controller.go
Auto-merging controllers/core/openstackversion_controller.go
Auto-merging controllers/client/openstackclient_controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Improve consistency of condition severity usage

Details

In response to this:

/cherry-pick 18.0-fr3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.