Convert baremetalSetTemplate field to pointer#1622
Conversation
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, rabi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As this field is optional we should make it a pointer which ensures proper optional validation i.e struct is optional, but if it is provided, some of its internal fields can be required. Depends-On: openstack-k8s-operators/openstack-baremetal-operator#328 Signed-off-by: rabi <ramishra@redhat.com>
|
New changes are detected. LGTM label has been removed. |
|
/test functional |
|
/test openstack-operator-build-deploy-kuttl-4-18 |
|
/test openstack-operator-build-deploy-kuttl-4-18 |
1 similar comment
|
/test openstack-operator-build-deploy-kuttl-4-18 |
|
openstack-operator-build-deploy-kuttl-4-18 seems to be failing consistently with |
|
/override ci/prow/openstack-operator-build-deploy-kuttl-4-18 |
|
@rabi: Overrode contexts on behalf of rabi: ci/prow/openstack-operator-build-deploy-kuttl-4-18 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
Bot
merged commit bb62bca
into
openstack-k8s-operators:main
3 participants
As this field is optional, we should make it a pointer that would ensure proper optional validation i.e struct is optional, but if it is provided, some of its internal fields can be required.