Skip to content

Storage request unit changes from M/G to Mi/Gi#1856

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
jhanzlic:unit_type_change
Mar 18, 2026
Merged

Storage request unit changes from M/G to Mi/Gi#1856
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
jhanzlic:unit_type_change

Conversation

@jhanzlic

@jhanzlic jhanzlic commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

Changed size units in samples and kuttl tests from SI to binary, according to
Jira: OSPRH-27441

@openshift-ci

openshift-ci Bot commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

Hi @jhanzlic. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions

Copy link
Copy Markdown

OpenStackControlPlane CRD Size Report

Metric Value
CRD JSON size 322136 bytes (315KB)
Base branch size 322136 bytes
Change +0.00%
Status yellow — growing
Threshold reference
Color Range Meaning
🟢 green < 300KB Comfortable
🟡 yellow 300–400KB Growing
🟠 orange 400–750KB Concerning
🔴 red > 750KB Approaching 1.5MB etcd limit (cut in half to allow space for update)

@jhanzlic jhanzlic marked this pull request as ready for review March 16, 2026 13:38
@openshift-ci openshift-ci Bot requested review from dprince and fultonj March 16, 2026 13:38
@abays

abays commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@stuggi stuggi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhanzlic, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi

stuggi commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

only failed on collect must-gather.

/override ci/prow/openstack-operator-build-deploy-kuttl-4-18

@openshift-ci

openshift-ci Bot commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

@stuggi: Overrode contexts on behalf of stuggi: ci/prow/openstack-operator-build-deploy-kuttl-4-18

Details

In response to this:

only failed on collect must-gather.

/override ci/prow/openstack-operator-build-deploy-kuttl-4-18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit 36856d2 into openstack-k8s-operators:main Mar 18, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants