Do not enable Northd Metrics when exporterImage is unset #479
Merged
openshift-merge-bot[bot] merged 2 commits intoSep 5, 2025
Merged
Conversation
For minor update scenarios we need to honor exporterImage as in older versions will not have OpenstackNetworkExporterImage set so exporterImage="". So with this patch metrics will be enabled only when metricsEnabled=true and exporterImage is set. Also removed the default image as now included in openstack-operator like other images, this was temporary change. Also dropped unnecessary log message when deployment do not exist. Related-Issue: https://issues.redhat.com/browse/OSPRH-12568 Depends-On: openstack-k8s-operators/openstack-operator#1587
Contributor
Author
|
/test ovn-operator-build-deploy-kuttl |
slawqo
approved these changes
Sep 5, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karelyatin, slawqo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit bfe70a8
into
openstack-k8s-operators:main
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not enable Northd Metrics when exporterImage is unset
For minor update scenarios we need to honor exporterImage as
in older versions will not have OpenstackNetworkExporterImage
set so exporterImage="".
So with this patch metrics will be enabled only when
metricsEnabled=true and exporterImage is set.
Also removed the default image as now included in
openstack-operator like other images, this was temporary
change.
Also dropped unnecessary log message when deployment do not exist.
Depends-On: openstack-k8s-operators/openstack-operator#1587
Related-Issue: https://issues.redhat.com/browse/OSPRH-12568